Subject: Re: [PATCH 03/04] Freescale Ethernet combined driver

From: Pantelis Antoniou <[email-masked]>
Date: Tue, 10 May 2005 15:15:39 +0300

Dan Malek wrote:
> 
> On May 10, 2005, at 7:17 AM, Pantelis Antoniou wrote:
> 
>> This patch replace iopa use with virt_to_phys.
> 
> 
> Not gonna work .....
> 
> When you map uncached on 8xx you get a new vmalloc()
> space.  The virt_to_xxx macros don't work on those addresses.
> You need to use the dma_consistent() function, stash the
> real physical address it returns and then use it where
> appropriate.
> 

Hmm. Correct. The dma_consistent() function will
do some cache flushing, but we don't really care about that
anyway.

Oh well. Patch will be forthcoming...

>> +    W32(ep, fen_genfcc.fcc_rbase, virt_to_phys(fep->rx_bd_base));
>> +    W32(ep, fen_genfcc.fcc_tbase, virt_to_phys(fep->tx_bd_base));
> 
> 
> I thought you were getting rid of these weirdo macros and
> write normal code for data structure access?  Please .....
> 

This is going to be difficult since the /net/drivers maintainer
insists on using them. I used to have direct data structure
accesses so it won't be difficult to change.

But we must have a consunsus.

> Thanks.
>     -- Dan

Regards

Pantelis