From: Randy Vinson <rvinson@mvista•com>
To: Eugene Surovegin <ebs@ebshome•net>
Cc: Greg KH <greg@kroah•com>,
sensors@stimpy•netroedge.com, linuxppc-embedded@ozlabs•org
Subject: Re: [PATCH 1/2] Add support for Maxim/Dallas DS1374 Real-Time Clock Chip
Date: Fri, 03 Jun 2005 15:17:56 -0700 [thread overview]
Message-ID: <42A0D714.1050601@mvista.com> (raw)
In-Reply-To: <20050603214653.GA15314@gate.ebshome.net>
Eugene Surovegin wrote:
[snip]
>
> I wonder, why you chose to use those 1-byte SMBus transfers instead of
> i2c transfer.
I was simply following the guidelines in
Documentation/i2c/writing-clients as noted in the driver header. This
note was in the driver I used as my base, so I just followed along.
>
> I wrote similar DS1374 driver some time ago which used those transfers
> and they worked just fine.
I checked http://secure.netroedge.com/~lm78/supported.html,
http://secure.netroedge.com/~lm78/newdrivers.html and looked in the
lm_sensors-2.9.1 tarball before I started and didn't see a driver for
the DS1374 listed. That's why I threw mine together. Maybe I missed it.
I would have used I2C transfers myself, but was simply following what I
thought were current practices. Since this is my first I2C client, I
just blindly followed the documentation :) Oh well, wouldn't be the
first time I wandered down the wrong path.
Randy Vinson
next prev parent reply other threads:[~2005-06-03 22:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-03 21:36 [PATCH 1/2] Add support for Maxim/Dallas DS1374 Real-Time Clock Chip Randy Vinson
2005-06-03 21:41 ` Kumar Gala
2005-06-03 22:05 ` Randy Vinson
2005-06-03 21:43 ` [PATCH 2/2] " Randy Vinson
2005-06-03 21:46 ` [PATCH 1/2] " Eugene Surovegin
2005-06-03 22:17 ` Randy Vinson [this message]
2005-06-09 17:25 ` [lm-sensors] " Jean Delvare
2005-06-09 19:06 ` Mark A. Greer
2005-06-09 19:29 ` Jean Delvare
2005-06-09 18:21 ` [lm-sensors] " Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42A0D714.1050601@mvista.com \
--to=rvinson@mvista$(echo .)com \
--cc=ebs@ebshome$(echo .)net \
--cc=greg@kroah$(echo .)com \
--cc=linuxppc-embedded@ozlabs$(echo .)org \
--cc=sensors@stimpy$(echo .)netroedge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox