Subject: Re: [PATCH] ppc32: add Freescale MPC885ADS board support

From: Andrei Konovalov <[email-masked]>
Date: Fri, 24 Jun 2005 20:29:02 +0400

Tom Rini wrote:
> On Fri, Jun 24, 2005 at 07:21:37PM +0400, Andrei Konovalov wrote:
> 
>>Hi Marcelo,
>>
>>Marcelo Tosatti wrote:
>>
>>>Hi Andrei,
>>>
>>>On Thu, Jun 23, 2005 at 07:38:54PM +0400, Andrei Konovalov wrote:
>>><snip>
>>>
>>>>diff --git a/arch/ppc/syslib/m8xx_setup.c b/arch/ppc/syslib/m8xx_setup.c
>>>>--- a/arch/ppc/syslib/m8xx_setup.c
>>>>+++ b/arch/ppc/syslib/m8xx_setup.c
>>>>@@ -369,7 +369,7 @@ m8xx_map_io(void)
>>>>#if defined(CONFIG_HTDMSOUND) || defined(CONFIG_RPXTOUCH) || 
>>>>defined(CONFIG_FB_RPX)
>>>>	io_block_mapping(HIOX_CSR_ADDR, HIOX_CSR_ADDR, HIOX_CSR_SIZE, 
>>>>	_PAGE_IO);
>>>>#endif
>>>>-#ifdef CONFIG_FADS
>>>>+#if defined(CONFIG_FADS) || defined(CONFIG_MPC885ADS)
>>>>	io_block_mapping(BCSR_ADDR, BCSR_ADDR, BCSR_SIZE, _PAGE_IO);
>>>>#endif
>>>>#ifdef CONFIG_PCI
>>>
>>>
>>>I suppose you also want to include CONFIG_MPC885ADS in the 
>>>io_block_mapping(IO_BASE) here?
>>
>>No, not at the moment at least.
>>Actually, the patch doesn't even #define IO_BASE.
>>In 2.4 that io_block_mapping(IO_BASE) was needed for PCMCIA / CF cards to 
>>work.
>>We haven't got to PCMCIA support in 2.6 yet, and PCMCIA is unlikely to work
>>as is in case of MPC885ADS, as drivers/pcmcia/m8xx_pcmcia.c is just missing.
>>We plan to address PCMCIA later.
> 
> 
> Lets just drop that hunk then..
> 

Do you mean not to use
   io_block_mapping(BCSR_ADDR, BCSR_ADDR, BCSR_SIZE, _PAGE_IO);
?

Thanks,
Andrei