From: Andrei Konovalov <akonovalov@ru•mvista.com>
To: Matt Porter <mporter@kernel•crashing.org>
Cc: linuxppc-embedded@ozlabs•org
Subject: [PATCH] ppc32: minor arch/ppc/syslib/xilinx_pic.c cleanups
Date: Wed, 29 Jun 2005 20:57:05 +0400 [thread overview]
Message-ID: <42C2D2E1.8060004@ru.mvista.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 329 bytes --]
For level sensitive interrupts the patch moves unmasking the interrupt behind
acknowledging it. It seems not to change anything in practice (experimented with
the ethernet a little bit), but looks more logical IMHO.
The second hunk removes two lines that do nothing.
Signed-off-by: Andrei Konovalov <akonovalov@ru•mvista.com>
[-- Attachment #2: xilinx_pic_cleanup.20050629.diff --]
[-- Type: text/plain, Size: 763 bytes --]
diff -Nupr a/arch/ppc/syslib/xilinx_pic.c b/arch/ppc/syslib/xilinx_pic.c
--- a/arch/ppc/syslib/xilinx_pic.c 2005-06-23 15:32:18.000000000 +0400
+++ b/arch/ppc/syslib/xilinx_pic.c 2005-06-29 18:28:44.000000000 +0400
@@ -71,10 +71,11 @@ xilinx_intc_end(unsigned int irq)
pr_debug("end: %d\n", irq);
if (!(irq_desc[irq].status & (IRQ_DISABLED | IRQ_INPROGRESS))) {
- intc_out_be32(intc + SIE, mask);
/* ack level sensitive intr */
if (irq_desc[irq].status & IRQ_LEVEL)
intc_out_be32(intc + IAR, mask);
+ /* unmask the interrupt */
+ intc_out_be32(intc + SIE, mask);
}
}
@@ -101,8 +102,6 @@ xilinx_pic_get_irq(struct pt_regs *regs)
*/
irq = intc_in_be32(intc + IVR);
- if (irq != -1)
- irq = irq;
pr_debug("get_irq: %d\n", irq);
reply other threads:[~2005-06-29 16:47 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42C2D2E1.8060004@ru.mvista.com \
--to=akonovalov@ru$(echo .)mvista.com \
--cc=linuxppc-embedded@ozlabs$(echo .)org \
--cc=mporter@kernel$(echo .)crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox