* [PATCH] ppc32: minor arch/ppc/syslib/xilinx_pic.c cleanups
@ 2005-06-29 16:57 Andrei Konovalov
0 siblings, 0 replies; only message in thread
From: Andrei Konovalov @ 2005-06-29 16:57 UTC (permalink / raw)
To: Matt Porter; +Cc: linuxppc-embedded
[-- Attachment #1: Type: text/plain, Size: 329 bytes --]
For level sensitive interrupts the patch moves unmasking the interrupt behind
acknowledging it. It seems not to change anything in practice (experimented with
the ethernet a little bit), but looks more logical IMHO.
The second hunk removes two lines that do nothing.
Signed-off-by: Andrei Konovalov <akonovalov@ru•mvista.com>
[-- Attachment #2: xilinx_pic_cleanup.20050629.diff --]
[-- Type: text/plain, Size: 763 bytes --]
diff -Nupr a/arch/ppc/syslib/xilinx_pic.c b/arch/ppc/syslib/xilinx_pic.c
--- a/arch/ppc/syslib/xilinx_pic.c 2005-06-23 15:32:18.000000000 +0400
+++ b/arch/ppc/syslib/xilinx_pic.c 2005-06-29 18:28:44.000000000 +0400
@@ -71,10 +71,11 @@ xilinx_intc_end(unsigned int irq)
pr_debug("end: %d\n", irq);
if (!(irq_desc[irq].status & (IRQ_DISABLED | IRQ_INPROGRESS))) {
- intc_out_be32(intc + SIE, mask);
/* ack level sensitive intr */
if (irq_desc[irq].status & IRQ_LEVEL)
intc_out_be32(intc + IAR, mask);
+ /* unmask the interrupt */
+ intc_out_be32(intc + SIE, mask);
}
}
@@ -101,8 +102,6 @@ xilinx_pic_get_irq(struct pt_regs *regs)
*/
irq = intc_in_be32(intc + IVR);
- if (irq != -1)
- irq = irq;
pr_debug("get_irq: %d\n", irq);
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2005-06-29 16:47 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-06-29 16:57 [PATCH] ppc32: minor arch/ppc/syslib/xilinx_pic.c cleanups Andrei Konovalov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox