From: Vitaly Bordug <vbordug@ru•mvista.com>
To: Marcelo Tosatti <marcelo.tosatti@cyclades•com>
Cc: linuxppc-embedded list <linuxppc-embedded@ozlabs•org>
Subject: Re: [PATCH] identify_ppc_sys_by_name_and_id function implementation final
Date: Thu, 11 Aug 2005 19:25:20 +0400 [thread overview]
Message-ID: <42FB6DE0.4070506@ru.mvista.com> (raw)
In-Reply-To: <20050811053032.GF5665@dmt.cnet>
Marcelo Tosatti wrote:
> On Wed, Aug 10, 2005 at 02:16:57PM -0500, Kumar Gala wrote:
>
>>+static int __init find_chip_by_name_and_id(char *name, u32 id)
>>+{
>>+ int ret = -1;
>>+ unsigned int i = 0;
>>+ unsigned int j = 0;
>>+ unsigned int dups = 0;
>>+
>>+ unsigned int matched[count_sys_specs()];
>>
>>Is is legit in the kernel to use dynamically sized array?
>
>
> kmalloc() is certainly safer - why not use it?
Practically , version with kmalloc works, but setup_arch and thus this
function is called before mem_init, so I just wonder if kmalloc can
handle this case. On the other hand, I don't like to deal with
alloc_bootmem() if mem_init_done!=1 and kmalloc otherwise (like ocp
does) just for the temporary buffer.
But it's the only _right_ way (or I 've missed something) - sure I'll
follow it.
--
Sincerely,
Vitaly
next prev parent reply other threads:[~2005-08-11 15:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-10 17:15 [RFC][PATCH] identify_ppc_sys_by_name_and_id function implementation Vitaly Bordug
2005-08-10 17:46 ` [PATCH] identify_ppc_sys_by_name_and_id function implementation (braces fixed) Vitaly Bordug
2005-08-10 18:01 ` [PATCH] identify_ppc_sys_by_name_and_id function implementation final Vitaly Bordug
2005-08-10 19:16 ` Kumar Gala
2005-08-11 5:30 ` Marcelo Tosatti
2005-08-11 15:25 ` Vitaly Bordug [this message]
2005-08-11 22:45 ` Marcelo Tosatti
2005-08-12 15:37 ` Vitaly Bordug
2005-08-12 16:18 ` Kumar Gala
2005-08-12 16:30 ` Vitaly Bordug
2005-08-12 19:48 ` Kumar Gala
2005-08-16 13:36 ` Vitaly Bordug
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42FB6DE0.4070506@ru.mvista.com \
--to=vbordug@ru$(echo .)mvista.com \
--cc=linuxppc-embedded@ozlabs$(echo .)org \
--cc=marcelo.tosatti@cyclades$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox