From: Michael Ellerman <patch-notifications@ellerman•id.au>
To: Rob Herring <robh@kernel•org>
Cc: Paul Mackerras <paulus@samba•org>,
linuxppc-dev <linuxppc-dev@lists•ozlabs.org>,
linux-kernel@vger•kernel.org
Subject: Re: [v2] powerpc: pseries: use of_irq_get helper in request_event_sources_irqs
Date: Thu, 4 Oct 2018 16:14:34 +1000 (AEST) [thread overview]
Message-ID: <42QjK66drTz9s7h@ozlabs.org> (raw)
In-Reply-To: <20180201175922.18930-1-robh@kernel.org>
On Thu, 2018-02-01 at 17:59:22 UTC, Rob Herring wrote:
> Instead of calling both of_irq_parse_one and irq_create_of_mapping, call
> of_irq_get instead which does essentially the same thing. of_irq_get
> also calls irq_find_host for deferred probe support, but this should be
> fine as irq_create_of_mapping also calls that internally. This gets us
> closer to making the former 2 functions static.
>
> In the process of simplifying request_event_sources_irqs, combine the
> the pr_err and WARN_ON calls to just a WARN().
>
> Cc: Benjamin Herrenschmidt <benh@kernel•crashing.org>
> Cc: Paul Mackerras <paulus@samba•org>
> Cc: Michael Ellerman <mpe@ellerman•id.au>
> Cc: linuxppc-dev@lists•ozlabs.org
> Signed-off-by: Rob Herring <robh@kernel•org>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/c417596d2409125b1814c05e994a21
cheers
prev parent reply other threads:[~2018-10-04 6:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-01 17:59 [PATCH v2] powerpc: pseries: use of_irq_get helper in request_event_sources_irqs Rob Herring
2018-10-04 6:14 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42QjK66drTz9s7h@ozlabs.org \
--to=patch-notifications@ellerman$(echo .)id.au \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=paulus@samba$(echo .)org \
--cc=robh@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox