From: Michael Ellerman <patch-notifications@ellerman•id.au>
To: Nicholas Piggin <npiggin@gmail•com>, linuxppc-dev@lists•ozlabs.org
Cc: Nicholas Piggin <npiggin@gmail•com>
Subject: Re: powerpc/64: Fix kernel stack 16-byte alignment
Date: Fri, 16 Nov 2018 00:25:02 +1100 (AEDT) [thread overview]
Message-ID: <42whtQ5c0pz9sBk@ozlabs.org> (raw)
In-Reply-To: <20181115023427.31033-1-npiggin@gmail.com>
On Thu, 2018-11-15 at 02:34:27 UTC, Nicholas Piggin wrote:
> Commit 4c2de74cc869 ("powerpc/64: Interrupts save PPR on stack rather
> than thread_struct") changed sizeof(struct pt_regs) % 16 from 0 to 8,
> which causes the interrupt frame allocation on kernel entry to put the
> kernel stack out of alignment.
>
> Add a pad field to fix alignment, and add a BUILD_BUG_ON to catch this
> in future.
>
> Fixes: 4c2de74cc869 ("powerpc/64: Interrupts save PPR on stack rather
> than thread_struct")
> Signed-off-by: Nicholas Piggin <npiggin@gmail•com>
Applied to powerpc fixes, thanks.
https://git.kernel.org/powerpc/c/66f93c5a02d5ba6ef17fef45914396
cheers
next prev parent reply other threads:[~2018-11-15 13:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-15 2:34 [PATCH] powerpc/64: Fix kernel stack 16-byte alignment Nicholas Piggin
2018-11-15 13:25 ` Michael Ellerman [this message]
2018-11-16 4:42 ` Abdul Haleem
2018-11-16 9:50 ` Sandipan Das
2018-11-16 12:46 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42whtQ5c0pz9sBk@ozlabs.org \
--to=patch-notifications@ellerman$(echo .)id.au \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=npiggin@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox