From: Michael Ellerman <patch-notifications@ellerman•id.au>
To: Breno Leitao <leitao@debian•org>, linuxppc-dev@lists•ozlabs.org
Cc: Breno Leitao <leitao@debian•org>
Subject: Re: [v2] powerpc/mm: Remove extern from function definition
Date: Tue, 27 Nov 2018 20:22:20 +1100 (AEDT) [thread overview]
Message-ID: <433ywr3jFNz9s8J@ozlabs.org> (raw)
In-Reply-To: <1540995851-26776-1-git-send-email-leitao@debian.org>
On Wed, 2018-10-31 at 14:24:11 UTC, Breno Leitao wrote:
> Function huge_ptep_set_access_flags() has the 'extern' keyword in the
> function definition and also in the function declaration. This causes a
> warning in 'sparse' since the 'extern' storage class should not be used
> in the function definition.
>
> arch/powerpc/mm/pgtable.c:232:12: warning: function 'huge_ptep_set_access_flags' with external linkage has definition
>
> This patch removes the keyword from the definition part. It also removes
> the extern keyword from the declaration part, since checkpatch --strict
> complains about it.
>
> Suggested-by: Christophe Leroy <christophe.leroy@c-s•fr>
> Signed-off-by: Breno Leitao <leitao@debian•org>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/bce85a167b336da80642952b222588
cheers
prev parent reply other threads:[~2018-11-27 9:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-31 14:24 [PATCH v2] powerpc/mm: Remove extern from function definition Breno Leitao
2018-11-27 9:22 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=433ywr3jFNz9s8J@ozlabs.org \
--to=patch-notifications@ellerman$(echo .)id.au \
--cc=leitao@debian$(echo .)org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox