From: "Rafael J. Wysocki" <rjw@rjwysocki•net>
To: Geert Uytterhoeven <geert+renesas@glider•be>,
Greg Kroah-Hartman <gregkh@linuxfoundation•org>
Cc: "Nishanth Menon" <nm@ti•com>, "David Airlie" <airlied@linux•ie>,
dri-devel@lists•freedesktop.org,
"Paulo Flabiano Smorigo" <pfsmorigo@gmail•com>,
"Breno Leitão" <leitao@debian•org>,
David@rox•of.borg, "Herbert Xu" <herbert@gondor•apana.org.au>,
"Kevin Hilman" <khilman@kernel•org>,
"Nayna Jain" <nayna@linux•ibm.com>,
amd-gfx@lists•freedesktop.org,
"Casey Leedom" <leedom@chelsio•com>,
linux-pm@vger•kernel.org,
"Pensando Drivers" <drivers@pensando•io>,
netdev@vger•kernel.org, linux-kernel@vger•kernel.org,
"David S . Miller" <davem@davemloft•net>,
linux-crypto@vger•kernel.org, "Daniel Vetter" <daniel@ffwll•ch>,
"Alex Deucher" <alexander.deucher@amd•com>,
"Paul Mackerras" <paulus@samba•org>,
"Shannon Nelson" <snelson@pensando•io>,
linuxppc-dev@lists•ozlabs.org,
"Christian König" <christian.koenig@amd•com>
Subject: Re: [PATCH 4/5] power: avs: smartreflex: Remove superfluous cast in debugfs_create_file() call
Date: Fri, 08 Nov 2019 12:24:42 +0100 [thread overview]
Message-ID: <4367615.jSCgeRn5tF@kreacher> (raw)
In-Reply-To: <20191021145149.31657-5-geert+renesas@glider.be>
On Monday, October 21, 2019 4:51:48 PM CET Geert Uytterhoeven wrote:
> There is no need to cast a typed pointer to a void pointer when calling
> a function that accepts the latter. Remove it, as the cast prevents
> further compiler checks.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider•be>
Greg, have you taken this one by any chance?
> ---
> drivers/power/avs/smartreflex.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/power/avs/smartreflex.c b/drivers/power/avs/smartreflex.c
> index 4684e7df833a81e9..5376f3d22f31eade 100644
> --- a/drivers/power/avs/smartreflex.c
> +++ b/drivers/power/avs/smartreflex.c
> @@ -905,7 +905,7 @@ static int omap_sr_probe(struct platform_device *pdev)
> sr_info->dbg_dir = debugfs_create_dir(sr_info->name, sr_dbg_dir);
>
> debugfs_create_file("autocomp", S_IRUGO | S_IWUSR, sr_info->dbg_dir,
> - (void *)sr_info, &pm_sr_fops);
> + sr_info, &pm_sr_fops);
> debugfs_create_x32("errweight", S_IRUGO, sr_info->dbg_dir,
> &sr_info->err_weight);
> debugfs_create_x32("errmaxlimit", S_IRUGO, sr_info->dbg_dir,
>
next prev parent reply other threads:[~2019-11-08 11:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-21 14:51 [PATCH 0/5] debugfs: Remove casts in debugfs_create_*() callers Geert Uytterhoeven
2019-10-21 14:51 ` [PATCH 1/5] crypto: nx - Improve debugfs_create_u{32, 64}() handling for atomics Geert Uytterhoeven
2019-10-25 15:27 ` [PATCH 1/5] crypto: nx - Improve debugfs_create_u{32,64}() " Herbert Xu
2019-10-21 14:51 ` [PATCH 2/5] cxgb4/cxgb4vf: Remove superfluous void * cast in debugfs_create_file() call Geert Uytterhoeven
2019-10-21 14:51 ` [PATCH 3/5] drm/amdgpu: " Geert Uytterhoeven
2019-10-28 17:56 ` Alex Deucher
2019-10-21 14:51 ` [PATCH 4/5] power: avs: smartreflex: Remove superfluous " Geert Uytterhoeven
2019-11-08 11:24 ` Rafael J. Wysocki [this message]
2019-11-08 11:37 ` Greg Kroah-Hartman
2019-11-13 11:02 ` Rafael J. Wysocki
2019-10-21 14:51 ` [PATCH 5/5] ionic: Use debugfs_create_bool() to export bool Geert Uytterhoeven
2019-10-21 16:35 ` Shannon Nelson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4367615.jSCgeRn5tF@kreacher \
--to=rjw@rjwysocki$(echo .)net \
--cc=David@rox$(echo .)of.borg \
--cc=airlied@linux$(echo .)ie \
--cc=alexander.deucher@amd$(echo .)com \
--cc=amd-gfx@lists$(echo .)freedesktop.org \
--cc=christian.koenig@amd$(echo .)com \
--cc=daniel@ffwll$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=dri-devel@lists$(echo .)freedesktop.org \
--cc=drivers@pensando$(echo .)io \
--cc=geert+renesas@glider$(echo .)be \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=herbert@gondor$(echo .)apana.org.au \
--cc=khilman@kernel$(echo .)org \
--cc=leedom@chelsio$(echo .)com \
--cc=leitao@debian$(echo .)org \
--cc=linux-crypto@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-pm@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=nayna@linux$(echo .)ibm.com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nm@ti$(echo .)com \
--cc=paulus@samba$(echo .)org \
--cc=pfsmorigo@gmail$(echo .)com \
--cc=snelson@pensando$(echo .)io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox