From: Florian Schirmer <jolt@tuxbox•org>
To: Marcelo Tosatti <marcelo.tosatti@cyclades•com>
Cc: obi@saftware•de, carjay@gmx•de,
linux-ppc-embedded <linuxppc-embedded@ozlabs•org>
Subject: Re: [PATCH] m8xx_wdt: software watchdog reset/interrupt select
Date: Tue, 15 Nov 2005 07:41:43 +0100 [thread overview]
Message-ID: <43798327.70305@tuxbox.org> (raw)
In-Reply-To: <20051114143821.GA28852@logos.cnet>
Hi,
> Note: From my reading of the documentation, even if the SWRI bit is
> unset (interrupt select mode), an NMI at IRQ0 should cause the system to
> jump to exception vector 0x100, resetting the system.
>
> So I'm wondering if the interrupt mode ever worked?
Never tried the interrupt mode. IMHO doesn't make much sense for a
watchdog. Why don't you simply set SWRI?
> +static void m8xx_wdt_timer_func(unsigned long data)
> +{
> + m8xx_wdt_reset();
> + m8xx_wdt_timer.expires = jiffies + 25;
> + add_timer(&m8xx_wdt_timer);
> +}
> +
> +void m8xx_wdt_install_timer(volatile immap_t *imap)
> +{
> + m8xx_wdt_timer.expires = jiffies + 25;
> + add_timer(&m8xx_wdt_timer);
> +}
m8xx_wdt_install_timer doesn't need imap and you could call it from
m8xx_wdt_timer_func to re-engange the timer resulting in less duplicated
code. Just a cosmetic thing though.
Best,
Florian
next prev parent reply other threads:[~2005-11-15 6:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-14 14:38 [PATCH] m8xx_wdt: software watchdog reset/interrupt select Marcelo Tosatti
2005-11-14 20:55 ` Kumar Gala
2005-11-14 15:57 ` [PATCH] m8xx_wdt: software watchdog reset/interrupt select\ Marcelo Tosatti
2005-11-14 16:03 ` Marcelo Tosatti
2005-11-14 21:14 ` Kumar Gala
2005-11-15 6:11 ` Florian Schirmer
2005-11-15 6:41 ` Florian Schirmer [this message]
2005-11-15 5:42 ` [PATCH] m8xx_wdt: software watchdog reset/interrupt select Marcelo Tosatti
2005-11-15 14:21 ` Marcelo Tosatti
2005-11-16 11:47 ` Florian Schirmer
2005-11-16 8:36 ` Marcelo Tosatti
2005-11-17 9:13 ` Florian Schirmer
2005-11-18 15:36 ` Marcelo Tosatti
2005-11-19 6:16 ` Florian Schirmer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43798327.70305@tuxbox.org \
--to=jolt@tuxbox$(echo .)org \
--cc=carjay@gmx$(echo .)de \
--cc=linuxppc-embedded@ozlabs$(echo .)org \
--cc=marcelo.tosatti@cyclades$(echo .)com \
--cc=obi@saftware$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox