public inbox for linuxppc-dev@ozlabs.org 
 help / color / mirror / Atom feed
From: Sylvain Munaut <tnt@246tNt•com>
To: John Rigby <jrigby@freescale•com>
Cc: linuxppc-embedded@ozlabs•org
Subject: Re: [PATCH] Add support for lite5200b board.
Date: Tue, 24 Jan 2006 19:17:56 +0100	[thread overview]
Message-ID: <43D66F54.8000404@246tNt.com> (raw)
In-Reply-To: <43D65FE3.6080501@freescale.com>

Hi John,

John Rigby wrote:
> Sylvain,
>
> Here is an updated patch for the liteb board.
>
> John


Looks good. But two comments :

 * Isn't a modif to the arch/ppc/platform/Makefile missing ?
 * What's the "cs-1" you turn on there :

>  
> +#ifdef CONFIG_LITE5200B
> +	/* turn on cs1 */
> +	port_config |= 0x80000000;
> +#endif

	I couldn't find the schema / real-doc of the Lite5200b,
is this available somewhere on-line ?




	Sylvain

  reply	other threads:[~2006-01-24 18:17 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-24 17:12 [PATCH] Add support for lite5200b board John Rigby
2006-01-24 18:17 ` Sylvain Munaut [this message]
2006-01-25 10:24   ` Txema Lopez
2006-01-25 23:21     ` Sylvain Munaut
2006-01-25 23:44       ` Grant Likely
2006-01-26 21:29       ` John Rigby
2006-01-29 22:21         ` Sylvain Munaut
2006-01-30 18:52           ` John Rigby
2006-01-30 20:29             ` Sylvain Munaut
2006-01-30 21:17               ` John Rigby
2006-01-30 22:17                 ` John Rigby
2006-01-30 22:22                   ` John Rigby
2006-01-30 23:45                     ` Sylvain Munaut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43D66F54.8000404@246tNt.com \
    --to=tnt@246tnt$(echo .)com \
    --cc=jrigby@freescale$(echo .)com \
    --cc=linuxppc-embedded@ozlabs$(echo .)org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox