From: "Jun'ichi Nomura" <j-nomura@ce•jp.nec.com>
To: Mark Maule <maule@sgi•com>
Cc: Tony Luck <tony.luck@intel•com>,
linux-ia64@vger•kernel.org, gregkh@suse•de,
linux-kernel@vger•kernel.org, linuxppc64-dev@ozlabs•org,
linux-pci@atrey•karlin.mff.cuni.cz
Subject: Re: [PATCH 1/3] msi vector targeting abstractions
Date: Tue, 21 Mar 2006 11:29:30 -0500 [thread overview]
Message-ID: <442029EA.9020900@ce.jp.nec.com> (raw)
In-Reply-To: <20060321143449.9913.55794.57267@lnx-maule.americas.sgi.com>
Hi Mark,
Mark Maule wrote:
> Index: linux-2.6.16/include/asm-ia64/msi.h
> ===================================================================
> --- linux-2.6.16.orig/include/asm-ia64/msi.h 2006-03-19 23:53:29.000000000 -0600
> +++ linux-2.6.16/include/asm-ia64/msi.h 2006-03-20 14:50:53.331368084 -0600
> @@ -14,4 +14,16 @@
> #define ack_APIC_irq ia64_eoi
> #define MSI_TARGET_CPU_SHIFT 4
>
> +extern struct msi_ops msi_apic_ops;
> +
> +static inline int msi_arch_init(void)
> +{
> + if (platform_msi_init)
> + return platform_msi_init();
> +
> + /* default ops for most ia64 platforms */
> + msi_register(&msi_apic_ops);
> + return 0;
> +}
> +
> #endif /* ASM_MSI_H */
It turned out that the above code breaks configs other
than CONFIG_IA64_SN and CONFIG_IA64_GENERIC.
e.g. CONFIG_IA64_DIG.
In file included from /build/16.msi/drivers/pci/msi.h:71,
from /build/16.msi/drivers/pci/msi.c:24:
include2/asm/msi.h: In function `msi_arch_init':
include2/asm/msi.h:22: error: called object is not a function
make[3]: *** [drivers/pci/msi.o] Error 1
Something like below might fix this problem:
if (platform_msi_init) {
ia64_mv_msi_init_t *fn = platform_msi_init;
return (*fn)();
}
Thanks,
--
Jun'ichi Nomura, NEC Solutions (America), Inc.
next prev parent reply other threads:[~2006-03-21 16:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-21 14:34 [PATCH 0/3] msi abstractions and support for altix Mark Maule
2006-03-21 14:34 ` [PATCH 1/3] msi vector targeting abstractions Mark Maule
2006-03-21 16:29 ` Jun'ichi Nomura [this message]
2006-03-21 16:38 ` Andreas Schwab
2006-03-21 19:14 ` Mark Maule
2006-03-21 19:23 ` Jun'ichi Nomura
2006-03-21 19:38 ` Mark Maule
2006-03-21 14:34 ` [PATCH 2/3] per-platform IA64_{FIRST,LAST}_DEVICE_VECTOR definitions Mark Maule
2006-03-21 14:34 ` [PATCH 3/3] altix: msi support Mark Maule
2006-03-21 21:53 ` [PATCH 0/3] msi abstractions and support for altix David S. Miller
-- strict thread matches above, loose matches on Subject: below --
2006-03-29 2:31 Mark Maule
2006-03-29 2:31 ` [PATCH 1/3] msi vector targeting abstractions Mark Maule
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=442029EA.9020900@ce.jp.nec.com \
--to=j-nomura@ce$(echo .)jp.nec.com \
--cc=gregkh@suse$(echo .)de \
--cc=linux-ia64@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-pci@atrey$(echo .)karlin.mff.cuni.cz \
--cc=linuxppc64-dev@ozlabs$(echo .)org \
--cc=maule@sgi$(echo .)com \
--cc=tony.luck@intel$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox