From: jschopp <jschopp@austin•ibm.com>
To: Michael Neuling <mikey@neuling•org>
Cc: linuxppc-dev@ozlabs•org, paulus@samba•org
Subject: Re: [PATCH] powerpc: whitespace cleanup in reg.h
Date: Tue, 09 May 2006 13:34:36 -0500 [thread overview]
Message-ID: <4460E0BC.4050908@austin.ibm.com> (raw)
In-Reply-To: <20060509163419.E4E1767A04@ozlabs.org>
> In reg.h we mostly have #define<space> but there are a few #define<tab>
> around. Clean these up so we use space exclusively.
>
> Signed-off-by: Michael Neuling <mikey@neuling•org>
nack
> +#define SPRN_HID6 0x3F9 /* BE HID 6 */
> +#define HID6_LB (0x0F<<12) /* Concurrent Large Page Modes */
> +#define HID6_DLP (1<<20) /* Disable all large page modes (4K only) */
> +#define SPRN_TSC_CELL 0x399 /* Thread switch control on Cell */
> +#define TSC_CELL_DEC_ENABLE_0 0x400000 /* Decrementer Interrupt */
> +#define TSC_CELL_DEC_ENABLE_1 0x200000 /* Decrementer Interrupt */
> +#define TSC_CELL_EE_ENABLE 0x100000 /* External Interrupt */
> +#define TSC_CELL_EE_BOOST 0x080000 /* External Interrupt Boost */
> +#define SPRN_TSC 0x3FD /* Thread switch control on others */
> +#define SPRN_TST 0x3FC /* Thread switch timeout on others */
OK, the tab to space for lines like SPRN_HID6 I understand. But then you seem to be
trying to do indenting with 3 spaces instead of tabs. And your values don't line up, and
your comments don't line up.
I'm just saying, either fix the formatting right or don't fix it at all. Moving it from
one ugly to another ugly is not worth the trouble.
next prev parent reply other threads:[~2006-05-09 18:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-09 16:33 [PATCH] powerpc: whitespace cleanup in reg.h Michael Neuling
2006-05-09 18:34 ` jschopp [this message]
2006-05-09 18:56 ` Hollis Blanchard
2006-05-09 19:01 ` Michael Neuling
2006-05-10 3:14 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4460E0BC.4050908@austin.ibm.com \
--to=jschopp@austin$(echo .)ibm.com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=mikey@neuling$(echo .)org \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox