Subject: Re: [PATCH] powerpc: whitespace cleanup in reg.h

From: jschopp <[email-masked]>
Date: Tue, 09 May 2006 13:34:36 -0500

> In reg.h we mostly have #define<space> but there are a few #define<tab>
> around.  Clean these up so we use space exclusively.
> 
> Signed-off-by: Michael Neuling <[email-masked]>

nack

> +#define SPRN_HID6	0x3F9	/* BE HID 6 */
> +#define   HID6_LB	(0x0F<<12) /* Concurrent Large Page Modes */
> +#define   HID6_DLP	(1<<20)	/* Disable all large page modes (4K only) */
> +#define SPRN_TSC_CELL	0x399	/* Thread switch control on Cell */
> +#define   TSC_CELL_DEC_ENABLE_0	0x400000 /* Decrementer Interrupt */
> +#define   TSC_CELL_DEC_ENABLE_1	0x200000 /* Decrementer Interrupt */
> +#define   TSC_CELL_EE_ENABLE	0x100000 /* External Interrupt */
> +#define   TSC_CELL_EE_BOOST	0x080000 /* External Interrupt Boost */
> +#define SPRN_TSC 	0x3FD	/* Thread switch control on others */
> +#define SPRN_TST 	0x3FC	/* Thread switch timeout on others */

OK, the tab to space for lines like SPRN_HID6 I understand.  But then you seem to be 
trying to do indenting with 3 spaces instead of tabs.  And your values don't line up, and 
your comments don't line up.

I'm just saying, either fix the formatting right or don't fix it at all.  Moving it from 
one ugly to another ugly is not worth the trouble.