From: Haren Myneni <haren@us•ibm.com>
To: Paul Mackerras <paulus@samba•org>, benh@kernel•crashing.org
Cc: linuxppc-dev@ozlabs•org
Subject: [PATCH] powerpc: EOI and clear IPI fix in xics_teardown_cpu()
Date: Sat, 08 Jul 2006 18:28:48 -0700 [thread overview]
Message-ID: <44B05BD0.304@us.ibm.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 697 bytes --]
If OK, please sent this patch to upstream.
Thanks
Haren
When invoked kdump boot, plpar_eoi() call is getting failed and calling
panic().
Kernel panic - not syncing: bad return code EOI - rc = -4, value=ff000000
The issue is with the desc->chip->eoi(XICS_IPI) in xics_teardown_cpu().
Instead of passing the virq to desc->chip->eoi(), XICS_IPI is used.
Also, clear IPI in xics_teardown_cpu() got removed recently (in
2.6.17-git25). Noticed in some crash dump cases (Ex: initiate kdump
boot using soft-reset and xmon is enabled), IPI is not cleared for some
CPU(s) before starting the kdump boot. Hence, causing the kdump boot
failure.
Signed-off-by: Haren Myneni <haren@us•ibm.com>
[-- Attachment #2: ppc64-kdump-fix-eoi-IPI.patch --]
[-- Type: text/x-patch, Size: 802 bytes --]
--- 2618-rc1/arch/powerpc/platforms/pseries/xics.c.orig 2006-07-08 11:47:58.000000000 -0700
+++ 2618-rc1/arch/powerpc/platforms/pseries/xics.c 2006-07-08 11:47:07.000000000 -0700
@@ -783,6 +783,14 @@ void xics_teardown_cpu(int secondary)
xics_set_cpu_priority(cpu, 0);
/*
+ * Clear IPI
+ */
+ if (firmware_has_feature(FW_FEATURE_LPAR))
+ lpar_qirr_info(cpu, 0xff);
+ else
+ direct_qirr_info(cpu, 0xff);
+
+ /*
* we need to EOI the IPI if we got here from kexec down IPI
*
* probably need to check all the other interrupts too
@@ -795,7 +803,7 @@ void xics_teardown_cpu(int secondary)
return;
desc = get_irq_desc(ipi);
if (desc->chip && desc->chip->eoi)
- desc->chip->eoi(XICS_IPI);
+ desc->chip->eoi(ipi);
/*
* Some machines need to have at least one cpu in the GIQ,
next reply other threads:[~2006-07-09 1:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-09 1:28 Haren Myneni [this message]
2006-07-09 1:37 ` [PATCH] powerpc: EOI and clear IPI fix in xics_teardown_cpu() Benjamin Herrenschmidt
2006-07-09 2:17 ` Haren Myneni
2006-07-09 4:08 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44B05BD0.304@us.ibm.com \
--to=haren@us$(echo .)ibm.com \
--cc=benh@kernel$(echo .)crashing.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox