public inbox for linuxppc-dev@ozlabs.org 
 help / color / mirror / Atom feed
* Re: [Alsa-devel] Linux v2.6.18-rc4, snd-aoa link error
       [not found]             ` <s5h7j1idrvf.wl%tiwai@suse.de>
@ 2006-08-09 12:29               ` Johannes Berg
  2006-08-09 12:31                 ` Takashi Iwai
  0 siblings, 1 reply; 4+ messages in thread
From: Johannes Berg @ 2006-08-09 12:29 UTC (permalink / raw)
  To: Takashi Iwai; +Cc: linuxppc-dev, Lee Revell, alsa-devel

Takashi Iwai wrote:
>> Yeah, I really should know :) But I'm not sure at the moment, and the 
>> powermac I own is a few hundred kilometers away...
>>     
>
> Don't worry, we can wait :)
>   
Maybe someone on linuxppc-dev can quickly check? Does a G5 use 
I2C_POWERMAC for access to the codecs? I think it does, but there are 
other I2C busses as well.
>> That looks good to me, and should get rid of the build failure. However, 
>> if one doesn't configure I2C_POWERMAC, no codec will ever be found at 
>> runtime.
>>     
>
> Yes, that's my concern, too.
>   
I'm not sure how much we should force the users to a sensible 
configuration ;) But I suppose selecting I2C_POWERMAC is fine for all 
relevant machines for now.

johannes

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Alsa-devel] Linux v2.6.18-rc4, snd-aoa link error
  2006-08-09 12:29               ` [Alsa-devel] Linux v2.6.18-rc4, snd-aoa link error Johannes Berg
@ 2006-08-09 12:31                 ` Takashi Iwai
  2006-08-09 12:38                   ` Johannes Berg
  0 siblings, 1 reply; 4+ messages in thread
From: Takashi Iwai @ 2006-08-09 12:31 UTC (permalink / raw)
  To: Johannes Berg; +Cc: linuxppc-dev, Lee Revell, alsa-devel

At Wed, 09 Aug 2006 14:29:38 +0200,
Johannes Berg wrote:
> 
> Takashi Iwai wrote:
> >> Yeah, I really should know :) But I'm not sure at the moment, and the 
> >> powermac I own is a few hundred kilometers away...
> >>     
> >
> > Don't worry, we can wait :)
> >   
> Maybe someone on linuxppc-dev can quickly check? Does a G5 use 
> I2C_POWERMAC for access to the codecs? I think it does, but there are 
> other I2C busses as well.
> >> That looks good to me, and should get rid of the build failure. However, 
> >> if one doesn't configure I2C_POWERMAC, no codec will ever be found at 
> >> runtime.
> >>     
> >
> > Yes, that's my concern, too.
> >   
> I'm not sure how much we should force the users to a sensible 
> configuration ;) But I suppose selecting I2C_POWERMAC is fine for all 
> relevant machines for now.

Agreed.

A relevant question: do we need I2C_POWERMAC for both onyx and tas?


Takashi

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Alsa-devel] Linux v2.6.18-rc4, snd-aoa link error
  2006-08-09 12:31                 ` Takashi Iwai
@ 2006-08-09 12:38                   ` Johannes Berg
  2006-08-09 12:52                     ` Takashi Iwai
  0 siblings, 1 reply; 4+ messages in thread
From: Johannes Berg @ 2006-08-09 12:38 UTC (permalink / raw)
  To: Takashi Iwai; +Cc: linuxppc-dev, Lee Revell, alsa-devel

Takashi Iwai wrote:
> A relevant question: do we need I2C_POWERMAC for both onyx and tas?
>   
Yes, there are PowerBooks and G5s with either. Actually, a bit more 
thinking about this I'm pretty sure that it is used on all G5s by way of 
how things are hooked up. There are SMU I2C busses too but they surely 
don't connect any sound i2c stuff.

johannes

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Alsa-devel] Linux v2.6.18-rc4, snd-aoa link error
  2006-08-09 12:38                   ` Johannes Berg
@ 2006-08-09 12:52                     ` Takashi Iwai
  0 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2006-08-09 12:52 UTC (permalink / raw)
  To: Johannes Berg; +Cc: linuxppc-dev, Lee Revell, alsa-devel

At Wed, 09 Aug 2006 14:38:38 +0200,
Johannes Berg wrote:
> 
> Takashi Iwai wrote:
> > A relevant question: do we need I2C_POWERMAC for both onyx and tas?
> >   
> Yes, there are PowerBooks and G5s with either. Actually, a bit more 
> thinking about this I'm pretty sure that it is used on all G5s by way of 
> how things are hooked up. There are SMU I2C busses too but they surely 
> don't connect any sound i2c stuff.

OK, now I added both I2C and I2C_POWERMAC and committed to ALSA tree.


Takashi

diff -r 67e0e0ca5f65 -r f72c2a462f76 aoa/codecs/Kconfig
--- a/aoa/codecs/Kconfig	Wed Aug 09 14:33:27 2006 +0200
+++ b/aoa/codecs/Kconfig	Wed Aug 09 14:51:14 2006 +0200
@@ -1,6 +1,8 @@ config SND_AOA_ONYX
 config SND_AOA_ONYX
 	tristate "support Onyx chip"
 	depends on SND_AOA
+	select I2C
+	select I2C_POWERMAC
 	---help---
 	This option enables support for the Onyx (pcm3052)
 	codec chip found in the latest Apple machines
@@ -18,6 +20,8 @@ config SND_AOA_TAS
 config SND_AOA_TAS
 	tristate "support TAS chips"
 	depends on SND_AOA
+	select I2C
+	select I2C_POWERMAC
 	---help---
 	This option enables support for the tas chips
 	found in a lot of Apple Machines, especially

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2006-08-09 12:52 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <Pine.LNX.4.64.0608061127070.5167@g5.osdl.org>
     [not found] ` <20060808194651.GA29482@aepfle.de>
     [not found]   ` <1155067429.26338.96.camel@mindpipe>
     [not found]     ` <s5hoduudypc.wl%tiwai@suse.de>
     [not found]       ` <44D9B1BE.9070600@sipsolutions.net>
     [not found]         ` <s5hk65idwia.wl%tiwai@suse.de>
     [not found]           ` <44D9C8E5.10109@sipsolutions.net>
     [not found]             ` <s5h7j1idrvf.wl%tiwai@suse.de>
2006-08-09 12:29               ` [Alsa-devel] Linux v2.6.18-rc4, snd-aoa link error Johannes Berg
2006-08-09 12:31                 ` Takashi Iwai
2006-08-09 12:38                   ` Johannes Berg
2006-08-09 12:52                     ` Takashi Iwai

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox