From: Sergei Shtylyov <sshtylyov@ru•mvista.com>
To: Kim Phillips <kim.phillips@freescale•com>
Cc: linuxppc-dev@ozlabs•org
Subject: Re: [PATCH] corrected PCI interrupt sense values to level low in mpc8349emds.dts
Date: Tue, 29 Aug 2006 19:35:33 +0400 [thread overview]
Message-ID: <44F45EC5.2070904@ru.mvista.com> (raw)
In-Reply-To: <44F45CDD.5060206@ru.mvista.com>
Hello, I wrote:
>> Corrected PCI interrupt sense values to level low in mpc8349emds.dts,
>> per Leo's recommendation.
>> Signed-off-by: Kim Phillips <kim.phillips@freescale•com>
>> ---
>> applies on top of "[PATCH 4/4] Add MPC8349E MDS device tree source
>> file to arch/powerpc/boot/dts"
>> arch/powerpc/boot/dts/mpc8349emds.dts | 112
>> +++++++++++++++++----------------
>> 1 files changed, 56 insertions(+), 56 deletions(-)
>>
>> diff --git a/arch/powerpc/boot/dts/mpc8349emds.dts
>> b/arch/powerpc/boot/dts/mpc8349emds.dts
>> index 7e4508b..0643db9 100644
>> --- a/arch/powerpc/boot/dts/mpc8349emds.dts
>> +++ b/arch/powerpc/boot/dts/mpc8349emds.dts
>> @@ -178,46 +178,46 @@
>> interrupt-map = <
>>
>> /* IDSEL 0x11 */
>> - 8800 0 0 1 700 14 0
>> - 8800 0 0 2 700 15 0
>> - 8800 0 0 3 700 16 0
>> - 8800 0 0 4 700 17 0
>> + 8800 0 0 1 700 14 2
>> + 8800 0 0 2 700 15 2
>> + 8800 0 0 3 700 16 2
>> + 8800 0 0 4 700 17 2
> Since when 2 means level low? 2 is level high, 1 is level low.
Ah, this board uses IPIC, not OpenPIC. Anyway, this contradicts your own
comment to the "ipic" device node stating that 8 is the right value for level low.
WBR, Sergei
prev parent reply other threads:[~2006-08-29 15:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-28 22:49 [PATCH] corrected PCI interrupt sense values to level low in mpc8349emds.dts Kim Phillips
2006-08-29 2:32 ` [PATCH] corrected PCI interrupt sense values to level low inmpc8349emds.dts Liu Dave-r63238
2006-08-30 13:29 ` Kumar Gala
2006-08-31 2:29 ` Liu Dave-r63238
2006-08-31 3:28 ` [PATCH] corrected PCI interrupt sense values to level lowinmpc8349emds.dts Li Yang-r58472
2006-08-31 4:46 ` Liu Dave-r63238
2006-08-29 6:48 ` [PATCH] corrected PCI interrupt sense values to level low in mpc8349emds.dts Paul Mackerras
2006-08-29 15:27 ` Sergei Shtylyov
2006-08-29 15:35 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44F45EC5.2070904@ru.mvista.com \
--to=sshtylyov@ru$(echo .)mvista.com \
--cc=kim.phillips@freescale$(echo .)com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox