From: Michael Ellerman <patch-notifications@ellerman•id.au>
To: "Tobin C. Harding" <tobin@kernel•org>,
Benjamin Herrenschmidt <benh@kernel•crashing.org>,
Paul Mackerras <paulus@samba•org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation•org>,
linuxppc-dev@lists•ozlabs.org,
"Tobin C. Harding" <tobin@kernel•org>,
linux-kernel@vger•kernel.org
Subject: Re: [PATCH] powerpc: Fix kobject memleak
Date: Fri, 3 May 2019 16:59:26 +1000 (AEST) [thread overview]
Message-ID: <44wNKW0jBxz9sPT@ozlabs.org> (raw)
In-Reply-To: <20190430010923.17092-1-tobin@kernel.org>
On Tue, 2019-04-30 at 01:09:23 UTC, "Tobin C. Harding" wrote:
> Currently error return from kobject_init_and_add() is not followed by a
> call to kobject_put(). This means there is a memory leak.
>
> Add call to kobject_put() in error path of kobject_init_and_add().
>
> Signed-off-by: Tobin C. Harding <tobin@kernel•org>
> Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation•org>
> Reviewed-by: Tyrel Datwyler <tyreld@linux•ibm.com>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/7e8039795a80bdf1418964b9cabef616
cheers
prev parent reply other threads:[~2019-05-03 7:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-30 1:09 [PATCH] powerpc: Fix kobject memleak Tobin C. Harding
2019-04-30 8:42 ` Greg Kroah-Hartman
2019-04-30 20:37 ` Tyrel Datwyler
2019-05-03 6:59 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44wNKW0jBxz9sPT@ozlabs.org \
--to=patch-notifications@ellerman$(echo .)id.au \
--cc=benh@kernel$(echo .)crashing.org \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=paulus@samba$(echo .)org \
--cc=tobin@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox