Subject: Re: [PATCH] powerpc: minor fix of numa message

From: Geoff Levand <[email-masked]>
Date: Sat, 16 Sep 2006 10:35:33 -0700

Michael Ellerman wrote:
> On Thu, 2006-09-14 at 08:17 -0700, Geoff Levand wrote:
>> This is a very minor fix that effects no current system.  The NUMA startup
>> message values for 'Top of RAM' and 'Memory hole size' were reported
>> incorrectly if more than one lmb region was added.
>> 
>> A comment in the lmb code states that lmb_analyze() must be called before
>> lmb_phys_mem_size().
> 
> But we've already called it in early_init_devtree()?

Yes, of course you are correct.  Updated patch follows.

-Geoff

This is a very minor comment change to the powerpc lbm code reflect current
usage.

Signed-off-by: Geoff Levand <[email-masked]>

---

Index: cell--common--4/arch/powerpc/mm/lmb.c
===================================================================
--- cell--common--4.orig/arch/powerpc/mm/lmb.c
+++ cell--common--4/arch/powerpc/mm/lmb.c
@@ -285,7 +285,9 @@
 	return base;
 }
 
-/* You must call lmb_analyze() before this. */
+/* You must call lmb_analyze() sometime before this, typcally just after
+ * adding regions.
+ */
 unsigned long __init lmb_phys_mem_size(void)
 {
 	return lmb.memory.size;