Subject: Re: [PATCH 2.6.19-rc1] ehea firmware interface based on Anton Blanchard's new hvcall interface

From: Jeff Garzik <[email-masked]>
Date: Wed, 27 Sep 2006 17:52:29 -0400

Jan-Bernd Themann wrote:
> Hi Jeff, 
> 
> the last patch did not work, so here is the new patch. The patch is build against
> git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/netdev.2.6.git HEAD today.
> Could you give it a try?

Per the standard patch format in Documentation/SubmittingPatches, these 
sort of comments should go beneath the "---" separator.  Otherwise, if 
they are not hand-edited out, they will go into the final changeset 
description.

> This eHEA patch reflects changes according to Anton's new hvcall interface
> which has been commited in Paul's git tree:
> 
> git://git.kernel.org/pub/scm/linux/kernel/git/paulus/powerpc.git

When is this going upstream?  I don't want things to get too out-of-sync.

> In addition to the above changes the patch includes a bug fix (port state
> notification) and minor changes (default queue length, coding style updates).

These changes should be in a separate patch.  Makes 'git bisect' work 
better, makes the changes more reviewable, and in general follows the 
"separate logical changes" rule.

> diff -Nurp netdev-2.6/drivers/net/ehea/ehea_ethtool.c netdev-2.6_patched/drivers/net/ehea/ehea_ethtool.c
> --- netdev-2.6/drivers/net/ehea/ehea_ethtool.c	2006-09-26 10:27:38.000000000 +0200
> +++ netdev-2.6_patched/drivers/net/ehea/ehea_ethtool.c	2006-09-26 19:28:22.000000000 +0200
> @@ -270,7 +270,7 @@ static void ehea_get_ethtool_stats(struc
>  	kfree(cb6);
>  }
>  
> -const struct ethtool_ops ehea_ethtool_ops = {
> +struct ethtool_ops ehea_ethtool_ops = {
>  	.get_settings = ehea_get_settings,
>  	.get_drvinfo = ehea_get_drvinfo,
>  	.get_msglevel = ehea_get_msglevel,

This is an obvious regression.

	Jeff