From: Nicolas DET <nd@bplan-gmbh•de>
To: Benjamin Herrenschmidt <benh@kernel•crashing.org>
Cc: linuxppc-dev@ozlabs•org, Sylvain Munaut <tnt@246tNt•com>,
sl@bplan-gmbh•de, linuxppc-embedded@ozlabs•org
Subject: Re: [PATCH/RFC] powerpc: Add MPC5200 Interrupt Controller support.
Date: Sun, 5 Nov 2006 14:16:54 +0100 (MET) [thread overview]
Message-ID: <454DE41C.3090609@bplan-gmbh.de> (raw)
In-Reply-To: <1162731733.28571.241.camel@localhost.localdomain>
[-- Attachment #1: Type: text/plain, Size: 1232 bytes --]
Benjamin Herrenschmidt wrote:
>> As said, no option here. I think there is different way to see how works the PIC. However, from a register point of view. There is just critical, main, peripherals, SDMA.
>>
>> Loot at "ICTL Perstat, MainStat, MainStat, CritStat Encoded Register--MBAR + 0x0524"
>
> You should have your device-tree match your internal numbering. As you
> noticed, the CRIT interrupt and the EXT interrupts are just the same.
As I see, they aren't.
Critical interrupts defines IRQ 0, as well as slice timer0, WakeUp from
deep-sleep mode (CCS) interrupt, etc..
Where as main is IRQ[1-3] as well as others stuff.
I did implement/change the irqchip, on your request, because in this
case (IRQ0 -> l2=1, IRQ[13] -> l2=1->3). and the ack/mask bit are the
same, it makes sense to have the same func called.
> So right now, what you should do is figure out a proper encoding for the
> firmware, and then either fix your device-tree, or do a hack in
> prom_init.c that fixes it up.
>
I think the OFW has proper encoding, moreover, this encoding was done up
on your request and opinion.
If you still want to change the Linux interrupt encoding, I will then
hack prom_init.c and submmit new patches...
Regards,
[-- Attachment #2: nd.vcf --]
[-- Type: text/x-vcard, Size: 249 bytes --]
begin:vcard
fn:Nicolas DET ( bplan GmbH )
n:DET;Nicolas
org:bplan GmbH
adr:;;;;;;Germany
email;internet:nd@bplan-gmbh•de
title:Software Entwicklung
tel;work:+49 6171 9187 - 31
x-mozilla-html:FALSE
url:http://www.bplan-gmbh.de
version:2.1
end:vcard
next prev parent reply other threads:[~2006-11-05 13:16 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-01 20:27 [PATCH/RFC] powerpc: Add MPC5200 Interrupt Controller support Nicolas DET
2006-11-01 22:05 ` Dale Farnsworth
2006-11-01 22:07 ` Sven Luther
2006-11-01 22:21 ` Dale Farnsworth
2006-11-01 22:12 ` Benjamin Herrenschmidt
2006-11-02 16:27 ` Nicolas DET
2006-11-02 20:47 ` Nicolas DET
2006-11-04 23:35 ` Benjamin Herrenschmidt
2006-11-05 0:27 ` Sylvain Munaut
2006-11-05 1:13 ` Benjamin Herrenschmidt
2006-11-06 6:28 ` Grant Likely
2006-11-06 8:39 ` Sylvain Munaut
2006-11-05 10:17 ` Nicolas DET
2006-11-05 10:37 ` Benjamin Herrenschmidt
2006-11-05 11:30 ` Nicolas DET
2006-11-05 13:02 ` Benjamin Herrenschmidt
2006-11-05 13:16 ` Nicolas DET [this message]
2006-11-05 14:32 ` Sylvain Munaut
2006-11-06 6:55 ` Grant Likely
-- strict thread matches above, loose matches on Subject: below --
2006-11-06 10:26 Nicolas DET
2006-11-06 11:03 Nicolas DET
2006-11-06 23:35 ` Sylvain Munaut
2006-11-07 9:22 ` Nicolas DET
2006-11-07 10:40 Nicolas DET
2006-11-07 10:45 ` Sylvain Munaut
2006-11-07 16:30 ` Grant Likely
2006-11-07 20:52 ` Sylvain Munaut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=454DE41C.3090609@bplan-gmbh.de \
--to=nd@bplan-gmbh$(echo .)de \
--cc=benh@kernel$(echo .)crashing.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=linuxppc-embedded@ozlabs$(echo .)org \
--cc=sl@bplan-gmbh$(echo .)de \
--cc=tnt@246tNt$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox