Subject: Re: [PATCH] adding ROM chips to device tree: respin

From: Sergei Shtylyov <[email-masked]>
Date: Wed, 08 Nov 2006 00:25:12 +0300

Hello.

Vitaly Wool wrote:
>>>+     - memory_space : Offset and length of the register set for the device.
>>
>>    NAK. There's no need to define an extra property where "reg" should be used.

> The register set is actually not there and depends on flash chip type.
> So using regs here is misleading.

    This is an I/O resource on the parent bus and using the property other 
than "reg" will be misleading.  That's the way this spec has it -- "reg" is 
used even for the PHY chip numbering on MDIO bus...

>>>+
>>>+	/*
>>>+	 * We care only about physmap devices now as there's no
>>>+	 * description defined for other ROM types yet
>>>+	 */

>>    Not true. The description only says that it's *most probably* compatible 
>>with "physmap", that's all. I don't see why we have to limit ourselves here.

> Effectively we care about NOR chips and similar which are
> memory-mapped. 

    So what? How "physmap" follows from this?

> Vitaly

WBR, Sergei