From: Geoff Levand <geoffrey.levand@am•sony.com>
To: michael@ellerman•id.au
Cc: linuxppc-dev@ozlabs•org, Arnd Bergmann <arnd.bergmann@de•ibm.com>,
cbe-oss-dev@ozlabs•org
Subject: Re: [Cbe-oss-dev] [PATCH 2/2] Add support for dumping spu info from xmon
Date: Fri, 10 Nov 2006 01:11:12 -0800 [thread overview]
Message-ID: <45544230.6070605@am.sony.com> (raw)
In-Reply-To: <1161154573.7906.11.camel@localhost.localdomain>
Michael Ellerman wrote:
> On Thu, 2006-10-12 at 10:42 -0700, Geoff Levand wrote:
>> Michael Ellerman wrote:
>> > This patch adds a command to xmon for dumping information about
>> > spu structs. The command is 'sf' for "spu fields" perhaps, and
>> > takes the spu number as an argument. This is the same value as the
>> > spu->number field, or the "phys-id" value of a context when it is
>> > bound to a physical spu.
>>
>> > +static void dump_spu_fields(struct spu *spu)
>> > +{
>> ...
>> > + DUMP_FIELD(spu, "0x%x", problem->spu_npc_RW);
>> > + DUMP_FIELD(spu, "0x%p", priv1);
>> > +
>> > + if (spu->priv1)
>> > + DUMP_FIELD(spu, "0x%lx", priv1->mfc_sr1_RW);
>> > +
>> > + DUMP_FIELD(spu, "0x%p", priv2);
>>
>> Just to let you know, I've been doing some work to abstract the platform
>> specific parts out of the spu support to better support running on a
>> hypervisor. It shouldn't make much difference, but maybe I'll try to set
>> something up like this for you:
>>
>> DUMP_FIELD(spu, "0x%x", problem->spu_npc_RW);
>> DUMP_FIELD(spu, "0x%p", priv2);
>> spu_dump_platform_fields(spu);
>
> We already have the spu_priv1_ops abstracted out, is that not enough? I
> decided to check explicitly for the priv1 pointer because calling the
> hypervisor from a panicked kernel is risky at best. Although I haven't
> seen how you guys implement hypervisor calls, so perhaps it's not so
> bad.
Michael,
I tried to set this up as above, but unfortunately, your DUMP_FIELD is
setup in such a way that it is not easy to change to use from outside
xmon.c, so I left spu_dump_platform_fields() (I put it in spu_priv1_mmio.c)
empty. We'll need to work on something usable here, or make some other way
to abstract those platform specific spu variables.
I'll re-post my abstract spu management routines patch again soon with
this xmon support added.
-Geoff
prev parent reply other threads:[~2006-11-10 9:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-12 12:03 [PATCH 0/2] Cell xmon helpers Michael Ellerman
2006-10-12 12:03 ` [PATCH 1/2] Add support for stopping spus from xmon Michael Ellerman
2006-10-12 16:18 ` Linas Vepstas
2006-10-18 7:13 ` Michael Ellerman
2006-10-13 3:10 ` Haren Myneni
2006-10-18 7:16 ` Michael Ellerman
2006-10-13 3:18 ` Luke Browning
2006-10-18 7:14 ` Michael Ellerman
2006-10-12 12:03 ` [PATCH 2/2] Add support for dumping spu info " Michael Ellerman
2006-10-12 17:42 ` [Cbe-oss-dev] " Geoff Levand
2006-10-18 6:56 ` Michael Ellerman
2006-11-10 9:11 ` Geoff Levand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45544230.6070605@am.sony.com \
--to=geoffrey.levand@am$(echo .)sony.com \
--cc=arnd.bergmann@de$(echo .)ibm.com \
--cc=cbe-oss-dev@ozlabs$(echo .)org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=michael@ellerman$(echo .)id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox