Subject: Re: [PATCH 7/16] powerpc: add support for ps3 platform

From: Geoff Levand <[email-masked]>
Date: Thu, 16 Nov 2006 17:33:21 -0800

Benjamin Herrenschmidt wrote:
>> > +
>> > +enum page_size {
>> > +	page_size_4k = 12U,
>> > +	page_size_64k = 16U,
>> > +	page_size_16m = 24U,
>> > +};
>> 
>> Please use ALL_CAPS for such constants.
> 
> And call them PAGE_SHIFT_* while at it :-)

The HV docs call this page size, so that is what I used for
the symbol.  I'll look at the usage again and reconsider.

-Geoff