From: Sergei Shtylyov <sshtylyov@ru•mvista.com>
To: Geoff Levand <geoffrey.levand@am•sony.com>
Cc: dwmw2@redhat•com, Paul Mackerras <paulus@samba•org>,
linuxppc-dev@ozlabs•org
Subject: Re: [PATCH] powerpc: fix build error in rom.c
Date: Wed, 06 Dec 2006 15:21:02 +0300 [thread overview]
Message-ID: <4576B5AE.90508@ru.mvista.com> (raw)
In-Reply-To: <45760109.8030200@am.sony.com>
Hello.
Geoff Levand wrote:
> Add missing include in rom.c. Fixes this build error when CONFIG_MTD=y:
> arch/powerpc/sysdev/rom.c:26: error: implicit declaration of function of_platform_device_create
Uh oh, that's what happens when someone doesn't respin the patches quickly
enough. Finally, the obsolete version has been committed -- it also misses one
property in the node spec and "reg" was called "regs" there...
> Signed-off-by: Geoff Levand <geoffrey.levand@am•sony.com>
>
> ---
> arch/powerpc/sysdev/rom.c | 1 +
> 1 files changed, 1 insertion(+)
>
> --- linux-2.6.19.ppc64.orig/arch/powerpc/sysdev/rom.c
> +++ linux-2.6.19.ppc64/arch/powerpc/sysdev/rom.c
> @@ -9,6 +9,7 @@
>
> #include <linux/kernel.h>
> #include <asm/of_device.h>
> +#include <asm/of_platform.h>
>
> static int __init powerpc_flash_init(void)
> {
WBR, Sergei
prev parent reply other threads:[~2006-12-06 12:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-05 23:30 [PATCH] powerpc: fix build error in rom.c Geoff Levand
2006-12-06 12:21 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4576B5AE.90508@ru.mvista.com \
--to=sshtylyov@ru$(echo .)mvista.com \
--cc=dwmw2@redhat$(echo .)com \
--cc=geoffrey.levand@am$(echo .)sony.com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox