Subject: Re: [patch 0/1] ipmi: update: add autosensing of ipmi devices on powerpc using of device tree

From: Corey Minyard <[email-masked]>
Date: Tue, 19 Dec 2006 12:01:55 -0600

Segher Boessenkool wrote:
>>> info->io_regsize = regsize ? *regsize : DEFAULT_REGSIZE;
>>>
>>> [Please note that fixes a copy/paste bug, too].
>>
>> There is no DEFAULT_REGSIZE, all the code is using DEFAULT_REGSPACING 
>> as the default size.
>> It looks like the code assumes that the registers are located next to 
>> each other.
>
> It would be more logical to only use REGSIZE then, heh.
>
>> If thats not good, DEFAULT_REGSIZE should be introduced and used in 
>> all other probe functions as well.
>> That would be a seperate issue .
>
> You could start the cleanup by doing
>
> #define DEFAULT_REGSIZE DEFAULT_REGSPACING
>
> and using REGSIZE in the new code.  Or replace s/REGSPACING/REGSIZE/
> throughout.  Or something.
>
> Not your fault though, just leave it as-is if you don't feel
> like fixing others' mess :-)
Doing this is fine with me, it needs to be done.

-Corey