From: Sylvain Munaut <tnt@246tNt•com>
To: Matt Sealey <matt@genesi-usa•com>
Cc: Linux PPC DEV <linuxppc-dev@ozlabs•org>,
bbrv@genesi-usa•com, Paul Mackerras <paulus@samba•org>,
David Woodhouse <dwmw2@infradead•org>
Subject: Re: [PATCH] Probe Efika platform before CHRP.
Date: Mon, 08 Jan 2007 00:38:15 +0100 [thread overview]
Message-ID: <45A18467.8070302@246tNt.com> (raw)
In-Reply-To: <45A17D1A.4050201@genesi-usa.com>
Matt Sealey wrote:
> So, giving it some other name is no problem at all. Just add the name
> into the
> list. You can never get rid of the list, and adding entries.. well..
> it may
> look clumsy, but it is not wrong! Especially if you're the first to
> name it.
> Linux should, I am saying, match against what the firmware provides, not
> vice-versa. I don't think it's logical for firmware vendors to keep
> changing
> names or maintain these huge lists...
For devices themselves (like serial, fec, ...), if there was only issues
there,
I must admit I'd consider just adding the other "compatible" property (look
at the current mpc52xx_uart.c driver, it has an entry only for the efika).
BUT :
- I'd really prefer to have it with the standard name, we're early
enough to
change it and I love consistency ;)
- The "other" name must _not_ conflict with the official one (and here
that's not the case, mpc5200-ata would trigger activation of 5200 errata
correction for ATA ... )
- You will anyway release an update so _why_ not change that, I haven't
heard so far a single good reason why not ...
- For more "system" parts (like bestcomm/sram/pic), there it's a lot more
annoying and I just want the received dt to exactly fit.
Since some changes couldn't be handled by just adding en entry to the
of_match
table (chrp type, missing irqs, sram type, ...) , I needed fixups anyway
so I
implemented all the fixups I'd like to see and deal with it in a single
place,
so at the end I have things exactly like for other 52xx boards ...
> just because of a philosophical difference
> on 2 lines of code in Linux? Especially when the other OS guys have
> not made
> any fuss..
But did the other OS support other 52xx board ? (question, I really
don't know)
If it only needed another "compatible" entry in the driver list of a
couple of
driver, and that there was no way the fw could ever change, I think we would
have (reluctantly ;) done it, but the problem is both deeper and the vendor
(you ;) have the clear opportunity to fix it better.
Sylvain
next prev parent reply other threads:[~2007-01-07 23:40 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-19 6:23 Bug fixes for 2.6.20 Paul Mackerras
2006-12-19 9:54 ` [PATCH] Probe Efika platform before CHRP David Woodhouse
2006-12-19 11:39 ` Benjamin Herrenschmidt
2006-12-19 11:55 ` Sylvain Munaut
2006-12-19 14:29 ` David Woodhouse
2006-12-19 15:46 ` Grant Likely
2006-12-19 19:58 ` Benjamin Herrenschmidt
2006-12-19 22:33 ` Sylvain Munaut
2007-01-02 21:29 ` David Woodhouse
2007-01-02 21:37 ` Benjamin Herrenschmidt
2007-01-02 22:04 ` David Woodhouse
2007-01-02 23:04 ` Grant Likely
[not found] ` <45A01416.6080401@genesi-usa.com>
2007-01-06 22:23 ` Grant Likely
2007-01-06 23:13 ` David Woodhouse
2007-01-06 23:37 ` Grant Likely
2007-01-07 2:55 ` Sylvain Munaut
2007-01-07 9:11 ` Raquel Velasco and Bill Buck
2007-03-31 13:15 ` David Woodhouse
2007-03-31 13:18 ` Raquel Velasco and Bill Buck
2007-03-31 13:21 ` David Woodhouse
2007-05-09 11:42 ` Olaf Hering
2007-05-09 11:45 ` Raquel Velasco and Bill Buck
2007-01-07 20:09 ` Matt Sealey
2007-01-07 20:24 ` Segher Boessenkool
2007-01-07 22:10 ` Matt Sealey
2007-01-07 22:35 ` Benjamin Herrenschmidt
2007-01-07 22:35 ` Sylvain Munaut
2007-01-07 23:04 ` Segher Boessenkool
2007-01-07 23:07 ` Matt Sealey
2007-01-07 23:38 ` Sylvain Munaut [this message]
2007-01-08 0:37 ` Benjamin Herrenschmidt
2007-01-07 22:32 ` Matt Sealey
2007-01-07 22:39 ` Matt Sealey
2007-01-07 23:27 ` Segher Boessenkool
2007-01-07 21:16 ` Benjamin Herrenschmidt
2007-01-08 2:17 ` David Woodhouse
2007-01-08 9:18 ` Matt Sealey
2007-01-08 12:52 ` Sylvain Munaut
2007-01-08 13:16 ` Sylvain Munaut
2007-01-08 17:25 ` Matt Sealey
2007-01-08 15:44 ` Sylvain Munaut
2007-01-08 17:25 ` Matt Sealey
2007-01-08 17:24 ` Matt Sealey
2007-01-08 17:59 ` Sylvain Munaut
2006-12-19 19:02 ` [PATCH] powerpc export rtas_set_slot_reset() Linas Vepstas
2006-12-19 22:08 ` Brian King
2006-12-19 19:06 ` [PATCH] powerpc fixup error message Linas Vepstas
2006-12-19 20:00 ` [PATCH] powerpc initialize pci device channel state Linas Vepstas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45A18467.8070302@246tNt.com \
--to=tnt@246tnt$(echo .)com \
--cc=bbrv@genesi-usa$(echo .)com \
--cc=dwmw2@infradead$(echo .)org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=matt@genesi-usa$(echo .)com \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox