From: Sylvain Munaut <tnt@246tNt•com>
To: Benjamin Herrenschmidt <benh@kernel•crashing.org>
Cc: Greg KH <gregkh@suse•de>, Linus Torvalds <torvalds@osdl•org>,
Linux Kernel Mailing List <linux-kernel@vger•kernel.org>,
linuxppc-dev@ozlabs•org,
Mariusz Kozlowski <m.kozlowski@tuxland•pl>,
paulus@samba•org
Subject: Re: Linux 2.6.20-rc4
Date: Tue, 09 Jan 2007 08:14:44 +0100 [thread overview]
Message-ID: <45A340E4.5030702@246tNt.com> (raw)
In-Reply-To: <1168308323.22458.254.camel@localhost.localdomain>
Benjamin Herrenschmidt wrote:
> On Mon, 2007-01-08 at 16:56 -0800, Greg KH wrote:
>> On Tue, Jan 09, 2007 at 11:38:59AM +1100, Benjamin Herrenschmidt wrote:
>>> On Mon, 2007-01-08 at 15:58 +0100, Sylvain Munaut wrote:
>>>> Don't build ohci as module for now.
>>>> A fix for that is already in gregkh usb tree for 2.6.21
>>> Do you mean that as-is, powerpc defconfigs cannot build USB as a module
>>> in 2.6.20 ? That is unacceptable as a regression. We need a fix in
>>> 2.6.20.
>>>
>>> Greg, what is the status there ?
>> Hm, for some reason I thought your patches were not needed until 2.6.21.
>
> My endian patches aren't, but Sylvain' are based on mines so ... Maybe
> if Sylvain rebases his ?
FWIW, the patch does apply fine (at least the first one, which is needed) :
tnt@hitomi linux-2.6-mpc52xx-new $ patch -p1 --dry-run <
ohci-rework-bus-glue-integration-to-allow-several-at-once.patch
patching file drivers/usb/host/ohci-at91.c
patching file drivers/usb/host/ohci-au1xxx.c
patching file drivers/usb/host/ohci-ep93xx.c
patching file drivers/usb/host/ohci-hcd.c
patching file drivers/usb/host/ohci-lh7a404.c
patching file drivers/usb/host/ohci-omap.c
patching file drivers/usb/host/ohci-pci.c
Hunk #1 succeeded at 238 (offset -73 lines).
patching file drivers/usb/host/ohci-pnx4008.c
patching file drivers/usb/host/ohci-pnx8550.c
patching file drivers/usb/host/ohci-ppc-soc.c
patching file drivers/usb/host/ohci-pxa27x.c
patching file drivers/usb/host/ohci-s3c2410.c
patching file drivers/usb/host/ohci-sa1111.c
The offset in ohci-pci.c is harmless.
But maybe the question we should ask is why would it build
drivers/usb/host/ohci-ppc-soc.c for an iMac G3 ... Because that problem
(ohci multiple glue in module) is there since a long time, just never
spotted before.
arch/powerpc/KConfig :
config PPC_EFIKA
bool "bPlan Efika 5k2. MPC5200B based computer"
depends on PPC_MULTIPLATFORM && PPC32
select PPC_RTAS
select RTAS_PROC
select PPC_MPC52xx
select PPC_NATIVE
default y
^^^
This was added by commit
c37858d333a50815c74349396e31a535f4128e0b on Nov5.
and a patch to correct that has been submitted recently :
http://patchwork.ozlabs.org/linuxppc/patch?id=8848
Sylvain
next prev parent reply other threads:[~2007-01-09 7:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Pine.LNX.4.64.0701062216210.3661@woody.osdl.org>
2007-01-08 14:50 ` Linux 2.6.20-rc4 Mariusz Kozlowski
2007-01-08 14:58 ` Sylvain Munaut
2007-01-08 15:03 ` Mariusz Kozlowski
2007-01-08 19:11 ` Jean Delvare
2007-01-09 0:38 ` Benjamin Herrenschmidt
2007-01-09 0:56 ` Greg KH
2007-01-09 2:05 ` Benjamin Herrenschmidt
2007-01-09 7:04 ` David Woodhouse
2007-01-09 7:04 ` Sylvain Munaut
2007-01-09 9:04 ` Benjamin Herrenschmidt
2007-01-09 7:14 ` Sylvain Munaut [this message]
2007-01-09 7:28 ` David Woodhouse
2007-01-09 9:08 ` Benjamin Herrenschmidt
2007-01-09 9:07 ` Benjamin Herrenschmidt
2007-01-09 7:18 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45A340E4.5030702@246tNt.com \
--to=tnt@246tnt$(echo .)com \
--cc=benh@kernel$(echo .)crashing.org \
--cc=gregkh@suse$(echo .)de \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=m.kozlowski@tuxland$(echo .)pl \
--cc=paulus@samba$(echo .)org \
--cc=torvalds@osdl$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox