From: Sylvain Munaut <tnt@246tNt•com>
To: Paul Mackerras <paulus@samba•org>
Cc: Linux PPC DEV <linuxppc-dev@ozlabs•org>
Subject: Re: [PATCH 3/4] powerpc: Use common 52xx of_platform probe code for EFIKA
Date: Tue, 09 Jan 2007 23:02:24 +0100 [thread overview]
Message-ID: <45A410F0.3090503@246tNt.com> (raw)
In-Reply-To: <17827.34251.87306.719371@cargo.ozlabs.ibm.com>
About the serial patch :
> I didn't put this one in for 2.6.20, because it doesn't solve any
> actual problem, and Ben H tells me it might trigger a bug in the
> generic irq code.
The bug it triggered has been fixed eons ago (like last December 22),
in a impressive one-liner patch that has 5 Signed-off/Acked-by ;) ...
But that code is rarely executed as it would imply the PSC can be
unloaded ... (impossible when used as console). So later merge
is OK.
Paul Mackerras wrote:
> Sylvain Munaut writes:
>
>
>> Now that the device tree has the good properties, we can
>> remove all the efika_init code by a single call to common code.
>>
>
> Ummm, but the device tree doesn't have good properties, does it,
> without your patch that adds a whole pile of device tree fixups?
> I'm reluctant to put that in for 2.6.20 because it's moderately large,
> has at least the potential to upset other platforms, and what it fixes
> isn't a regression from 2.6.19, and we're already past -rc4.
>
Ok, let's just delay everything to the next merge window. Anyway most
the drivers won't get merged until then.
I'll redo a nice patchset with all I got when it opens (or if you open a
for-2.6.21 branch ;).
Sylvain
next prev parent reply other threads:[~2007-01-09 22:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-02 22:29 [PATCH 0/4] 52xx fixes for 2.6.20 Sylvain Munaut
2007-01-02 22:29 ` [PATCH 1/4] powerpc/serial: Dispose irq mapping when done in mpc52xx_serial.c Sylvain Munaut
2007-01-02 22:29 ` [PATCH 2/4] powerpc: 52xx, Don't use device_initcall to probe of_platform_bus Sylvain Munaut
2007-01-02 22:29 ` [PATCH 3/4] powerpc: Use common 52xx of_platform probe code for EFIKA Sylvain Munaut
2007-01-02 22:29 ` [PATCH 4/4] powerpc: Restore 'proper' link order in platform Sylvain Munaut
2007-01-02 22:51 ` Grant Likely
2007-01-02 22:53 ` [PATCH 3/4] powerpc: Use common 52xx of_platform probe code for EFIKA Grant Likely
2007-01-09 12:08 ` Paul Mackerras
2007-01-09 22:02 ` Sylvain Munaut [this message]
2007-01-11 2:56 ` Benjamin Herrenschmidt
2007-01-02 22:52 ` [PATCH 2/4] powerpc: 52xx, Don't use device_initcall to probe of_platform_bus Grant Likely
2007-01-02 22:51 ` [PATCH 1/4] powerpc/serial: Dispose irq mapping when done in mpc52xx_serial.c Grant Likely
2007-01-09 12:05 ` Paul Mackerras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45A410F0.3090503@246tNt.com \
--to=tnt@246tnt$(echo .)com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox