Subject: Re: [PATCH] ps3_free_io_irq: inverted error check

From: Geoff Levand <[email-masked]>
Date: Fri, 12 Jan 2007 09:16:16 -0800

Geert Uytterhoeven wrote:
> ps3_free_io_irq: Fix inverted error check after calling
> lv1_destruct_io_irq_outlet()
> 
> Signed-off-by: Geert Uytterhoeven <[email-masked]>
> 
> ---
>  arch/powerpc/platforms/ps3/interrupt.c |    2 +-
>  1 files changed, 1 insertion(+), 1 deletion(-)
> 
> --- ps3-linux-src.orig/arch/powerpc/platforms/ps3/interrupt.c
> +++ ps3-linux-src/arch/powerpc/platforms/ps3/interrupt.c
> @@ -71,7 +71,7 @@ int ps3_free_io_irq(unsigned int virq)
>  
>  	result = lv1_destruct_io_irq_outlet(virq_to_hw(virq));
>  
> -	if (!result)
> +	if (result)
>  		pr_debug("%s:%d: lv1_destruct_io_irq_outlet failed: %s\n",
>  			__func__, __LINE__, ps3_result(result));
>  
> 

Paul,

If you don't see any trouble, it would be nice for this to go in
for 2.6.20, as it fixes a problem currently in Linus' tree.

Sorry it took so long to merge in and test.

Acked-by: Geoff Levand <[email-masked]>

-Geoff