Subject: Re: [PATCH 1/4] libata.h: add another IRQ calls

From: Jeff Garzik <[email-masked]>
Date: Wed, 24 Jan 2007 20:10:45 -0500

Akira Iguchi wrote:
> Two IRQ calls are added in ata_port_operations.
> - irq_on() is used to enable interrupts. 
> - irq_ack() is used to acknowledge a device interrupt.
> 
> And there are additional function declarations which are
> used in pata_scc.c.
> 
> Signed-off-by: Kou Ishizaki <[email-masked]>
> Signed-off-by: Akira Iguchi <[email-masked]>

After this round of comments, please resend the entire patchset, so that 
I have everything straight.

> @@ -761,6 +763,9 @@ extern void ata_port_queue_task(struct a
>  extern u32 ata_wait_register(void __iomem *reg, u32 mask, u32 val,
>  			     unsigned long interval_msec,
>  			     unsigned long timeout_msec);
> +unsigned int ata_dev_try_classify(struct ata_port *, unsigned int, u8 *);
> +struct ata_probe_ent *ata_probe_ent_alloc(struct device *,
> +					  const struct ata_port_info *);
>  

To properly export these functions, (a) remove their declarations from 
drivers/ata/libata.h and (b) add EXPORT_SYMBOL_GPL() declarations.

	Jeff