Subject: Re: [PATCH] driver/ata: PATA driver for Celleb

From: Jeff Garzik <[email-masked]>
Date: Wed, 24 Jan 2007 20:20:33 -0500

Akira Iguchi wrote:
> This is the patch for PATA controller of Celleb.
> It depends on the previous "add another IRQ calls" patch.
> 
> Because this driver needs special taskfile accesses, there is
> a copy of ata_std_softreset(). ata_dev_try_classify() is exported
> so that it can be used in this function.
> 
> Signed-off-by: Kou Ishizaki <[email-masked]>
> Signed-off-by: Akira Iguchi <[email-masked]>

The driver looks OK, the only thing I wonder is:  can you use the iomap 
interface to eliminate the rest of the duplicated code?

See Tejun's latest patchset "[PATCHSET] Managed device resources, take 
#3" which completes the conversion of libata to using the lib/iomap.c 
interface.

	Jeff