From: Geoff Levand <geoffrey.levand@am•sony.com>
To: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom•com>
Cc: paulus@samba•org, linuxppc-dev@ozlabs•org
Subject: Re: [PATCH 9/14] ps3: add interrupt alloc for outlets
Date: Thu, 25 Jan 2007 15:56:36 -0800 [thread overview]
Message-ID: <45B943B4.5090204@am.sony.com> (raw)
In-Reply-To: <Pine.LNX.4.62.0701251433330.31896@pademelon.sonytel.be>
Geert Uytterhoeven wrote:
> On Thu, 25 Jan 2007, Benjamin Herrenschmidt wrote:
>> > +int ps3_alloc_irq(enum ps3_cpu_binding cpu, unsigned long outlet,
>> > + unsigned int *virq)
>> > +{
>> > + return ps3_connect_irq(cpu, outlet, virq);
>> > +}
>> > +
>> > +int ps3_free_irq(unsigned int virq)
>> > +{
>> > + ps3_disconnect_irq(virq);
>> > + return 0;
>> > +}
>> > +
>> > #define PS3_INVALID_OUTLET ((irq_hw_number_t)-1)
>> > #define PS3_PLUG_MAX 63
>>
>> I'm not too fan of this... those 2 functions do strictly -nothing- other
>> than export the ones they call (not even changing arguments).
>>
>> So why not export ps3_connect_irq / ps3_disconnect_irq directly ?
>
> You're right. Originally they were all but trivial wrappers, but the recent
> interrupt improvements have changed this.
>
> Do you have a preference which names to keep?
>
> 1. ps3_connect_irq() and ps3_disconnect_irq() resemble the LV1 calls they
> make,
> 2. ps3_alloc_irq() and ps3_free_irq() resemble the other
> ps3_{alloc,free}_*_irq() names.
I think ps3_connect_irq() and ps3_disconnect_irq() are not consistent with
the existing routines, so I would perfer not to use those. I'll post a new
patch that makes this change.
-Geoff
next prev parent reply other threads:[~2007-01-25 23:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-25 2:40 [PATCH 9/14] ps3: add interrupt alloc for outlets Geoff Levand
2007-01-25 3:55 ` Benjamin Herrenschmidt
2007-01-25 13:41 ` Geert Uytterhoeven
2007-01-25 23:56 ` Geoff Levand [this message]
2007-01-26 2:48 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45B943B4.5090204@am.sony.com \
--to=geoffrey.levand@am$(echo .)sony.com \
--cc=Geert.Uytterhoeven@sonycom$(echo .)com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox