Subject: Re: [PATCH 1/14] ps3: repository misc fixes

From: Geoff Levand <[email-masked]>
Date: Fri, 26 Jan 2007 12:39:58 -0800

Christoph Hellwig wrote:
> On Fri, Jan 26, 2007 at 03:57:41AM +0100, Christoph Hellwig wrote:
>> On Wed, Jan 24, 2007 at 06:39:37PM -0800, Geoff Levand wrote:
>> > +EXPORT_SYMBOL_GPL(ps3_repository_read_bus_id);
>> 
>> > +EXPORT_SYMBOL_GPL(ps3_repository_read_bus_type);
>> 
>> > +EXPORT_SYMBOL_GPL(ps3_repository_read_bus_num_dev);
>> 
>> > +EXPORT_SYMBOL_GPL(ps3_repository_read_dev_id);
>> 
>> > +EXPORT_SYMBOL_GPL(ps3_repository_read_dev_type);
>> 
>> > +EXPORT_SYMBOL_GPL(ps3_repository_read_dev_intr);
>> 
>> > +EXPORT_SYMBOL_GPL(ps3_repository_find_device);
>> 
>> > +EXPORT_SYMBOL_GPL(ps3_repository_read_stor_dev_info);
>> 
>> > +EXPORT_SYMBOL_GPL(ps3_repository_read_stor_dev_region);
>> 
>> 
>> Exporting all these as procedural interfaces is very wrong.  Please
>> implement a proper bustype for your hypervisor devices where all this
>> information is an attribute of the hv1_device object.
> 
> In addition to that there's no user of these exports in this patch,
> so there is no point in adding any kind of export for this type of
> information at all yet.  (until we have a proper storage driver)

Both good points.  I'll remove this from the patch and rework it
for later submission.

-Geoff