From: Geoff Levand <geoffrey.levand@am•sony.com>
To: Christoph Hellwig <hch@lst•de>
Cc: Paul Mackerras <paulus@samba•org>, linuxppc-dev@ozlabs•org
Subject: Re: [PATCH 4/16] ps3: system bus minor mmio fix
Date: Mon, 29 Jan 2007 11:32:40 -0800 [thread overview]
Message-ID: <45BE4BD8.4050701@am.sony.com> (raw)
In-Reply-To: <20070128084239.GA6311@lst.de>
Christoph Hellwig wrote:
> On Sun, Jan 28, 2007 at 07:06:57AM +1100, Benjamin Herrenschmidt wrote:
>> Note that I personally think that drivers/ps3 is a very wrong place for
>> the ps3 system bus. It should stay in arch/powerpc/platform/ps3
>
> Yes, absolutely. We should not spreads things all over the tree do
> make understanding the code even more difficult than all the lv1
> braindamage already makes it.
I'm really disappointed that you both feel that way. Why didn't you say so several
months ago when I first posted that? I also don't think it is a good place, since
I need to expose a bunch of platform specifics in asm-powerpc/ps3.h, which would
better stay in my platform/ps3/platform.h. When I had that stuff in the platform
directory there was criticism that it shouldn't go there, so I moved it out. I'll
make a patch for RFC and see what happens.
-Geoff
next prev parent reply other threads:[~2007-01-29 19:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-27 3:07 [PATCH 4/16] ps3: system bus minor mmio fix Geoff Levand
2007-01-27 20:06 ` Benjamin Herrenschmidt
2007-01-28 8:42 ` Christoph Hellwig
2007-01-29 19:32 ` Geoff Levand [this message]
2007-01-29 20:16 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45BE4BD8.4050701@am.sony.com \
--to=geoffrey.levand@am$(echo .)sony.com \
--cc=hch@lst$(echo .)de \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox