From: Geoff Levand <geoffrey.levand@am•sony.com>
To: Scott Wood <scottwood@freescale•com>
Cc: linuxppc-dev@ozlabs•org
Subject: Re: [PATCH 19/19] bootwrapper: compatibility layer for old U-Boots (a.k.a. cuImage, cuboot)
Date: Mon, 12 Feb 2007 13:38:52 -0800 [thread overview]
Message-ID: <45D0DE6C.1040207@am.sony.com> (raw)
In-Reply-To: <20070212205438.GB17285@ld0162-tx32.am.freescale.net>
Scott Wood wrote:
> diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
> index aeb5309..f6e9b5e 100644
> --- a/arch/powerpc/Kconfig
> +++ b/arch/powerpc/Kconfig
> +config CUIMAGE_DTS
> + string "Device tree source file"
> + depends on COMPAT_UIMAGE
> + help
> + This specifies the device tree source (.dts) file to
> + be compiled and included in the kernel image. If
> + a relative filename is given, then it will be relative
> + to arch/powerpc/boot/dts.
> +
There is nothing CUIMAGE specific with this, so why make it so? Other
platforms may like to use it.
> +++ b/arch/powerpc/boot/Makefile
> @@ -35,6 +35,8 @@ endif
>
> BOOTCFLAGS += -I$(obj) -I$(srctree)/$(obj)
>
> +cuboot-plats := 83xx 85xx 86xx
> +
> zlib := inffast.c inflate.c inftrees.c
> zlibheader := inffast.h inffixed.h inflate.h inftrees.h infutil.h
> zliblinuxheader := zlib.h zconf.h zutil.h
> @@ -45,7 +47,7 @@ $(addprefix $(obj)/,$(zlib) main.o): $(a
> src-wlib := string.S stdio.c main.c flatdevtree.c flatdevtree_misc.c \
> ns16550.c serial.c simple_alloc.c div64.S util.S $(zlib) \
> devtree.c
> -src-plat := of.c
> +src-plat := of.c $(cuboot-plats:%=cuboot-%.c)
It may be better to do it like this, as there will be more platforms that
need to hook in specific files.
src-plat-$(CONFIG_COMPAT_UIMAGE) += $(cuboot-plats:%=cuboot-%.c)
src-plat-$(CONFIG_XXX) += ...
src-plat-$(CONFIG_YYY) += ...
...
src-plat := of.c $(src-plat-y)
> +ifeq ($(CONFIG_COMPAT_UIMAGE),y)
> +cuboot-plat-$(CONFIG_83xx) += 83xx
> +cuboot-plat-$(CONFIG_85xx) += 85xx
> +cuboot-plat-$(CONFIG_86xx) += 86xx
> +cuboot-plat-y += unknown-platform
> +
> +$(obj)/uImage: vmlinux $(wrapperbits)
> + $(call cmd,wrap_dt,cuboot-$(word 1,$(cuboot-plat-y)))
> +else
> $(obj)/uImage: vmlinux $(wrapperbits)
> $(call cmd,wrap,uboot)
> +endif
It would be nice if you could make the logic such that you don't need this ifeq.
-Geoff
next prev parent reply other threads:[~2007-02-12 21:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-12 20:54 [PATCH 19/19] bootwrapper: compatibility layer for old U-Boots (a.k.a. cuImage, cuboot) Scott Wood
2007-02-12 21:38 ` Geoff Levand [this message]
2007-02-13 16:13 ` Scott Wood
2007-02-13 17:32 ` Geoff Levand
2007-02-18 0:22 ` David Gibson
-- strict thread matches above, loose matches on Subject: below --
2007-02-07 23:00 [PATCH 00/19] cuboot bootwrapper patchset Scott Wood
2007-02-07 23:01 ` [PATCH 19/19] bootwrapper: compatibility layer for old U-Boots (a.k.a. cuImage, cuboot) Scott Wood
2007-02-08 21:15 ` David Gibson
2007-02-09 17:11 ` Scott Wood
2007-02-10 1:02 ` David Gibson
2007-02-12 16:52 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45D0DE6C.1040207@am.sony.com \
--to=geoffrey.levand@am$(echo .)sony.com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=scottwood@freescale$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox