From: Sergei Shtylyov <sshtylyov@ru•mvista.com>
To: Timur Tabi <timur@freescale•com>
Cc: linuxppc-dev@ozlabs•org, paulus@samba•org
Subject: Re: [PATCH] Check mac-address first in fsl_soc.c
Date: Tue, 13 Feb 2007 20:33:13 +0300 [thread overview]
Message-ID: <45D1F659.6090106@ru.mvista.com> (raw)
In-Reply-To: <45D1F46C.4050901@freescale.com>
Hello.
Timur Tabi wrote:
>> I'm mainly concerned about 85xx. I guess the needed change should
>> be very alike...
> I've submitted U-Boot patches for 83xx, 85xx, 86xx, and 5xxx to the
> maintainers. You'll have to ask them when the patches will be applied.
In fact, I/'m regretting not fixing this myself -- Andy said it'll be
fixed RSN and it took about 2 months (actually, more since the issue was first
noticed by me in October)...
>>> I wanted to keep my patch simple.
>> That's clearly an over-simplification to repeat the same code thrice.
> Actually, the 2nd and third instances are conditionally compiled, so in
I think that's a bad excuse. You could have coded inline function at least.
> most cases only one instance of the code will actually be compiled.
> gfar_of_init() should probably also be conditionally compiled, so if I
But it's not?
> make it a separate function, I'd have to prefix it with something like
> this:
> #if defined(CONFIG_GIANFAR) || defined(CONFIG_CPM2) || defined(CONFIG_8xx)
> and then I would need to pass a bunch of parameters. I don't really
> think that's an improvement.
> Paul, if there are no serious objections, please apply this patch.
I object -- such practice produces the code that is harder to change and
which is more likely to get out of sync between the 3 instances later. :-/
WBR, Sergei
next prev parent reply other threads:[~2007-02-13 17:33 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-09 20:02 [PATCH] Check mac-address first in fsl_soc.c Timur Tabi
2007-02-09 20:52 ` Sergei Shtylyov
2007-02-09 20:55 ` Timur Tabi
2007-02-09 20:58 ` Sergei Shtylyov
2007-02-09 21:00 ` Timur Tabi
2007-02-09 21:06 ` Kumar Gala
2007-02-09 21:09 ` Timur Tabi
2007-02-13 17:25 ` Timur Tabi
2007-02-13 17:33 ` Sergei Shtylyov [this message]
2007-02-13 17:37 ` Timur Tabi
2007-02-13 17:37 ` Kumar Gala
2007-02-13 17:45 ` Timur Tabi
2007-02-13 18:01 ` Kumar Gala
2007-02-13 18:51 ` Timur Tabi
2007-02-13 19:01 ` Kumar Gala
2007-02-13 19:10 ` Timur Tabi
2007-02-13 19:20 ` Timur Tabi
2007-02-13 19:50 ` Timur Tabi
2007-02-13 21:23 ` Timur Tabi
2007-02-13 22:14 ` Kumar Gala
2007-02-09 21:24 ` Jerry Van Baren
2007-02-09 21:51 ` Timur Tabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45D1F659.6090106@ru.mvista.com \
--to=sshtylyov@ru$(echo .)mvista.com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=paulus@samba$(echo .)org \
--cc=timur@freescale$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox