Subject: Re: [PATCH] powerpc: add of_get_mac_address() and update fsl_soc.c to use it

From: Sergei Shtylyov <[email-masked]>
Date: Wed, 14 Feb 2007 17:09:08 +0300

Hello.

Timur Tabi wrote:

>>> +    return get_property(np, "address", NULL);

>> Since there is so much room for confusion with "address", please at
>> least do some basic sanity checking, like check that it's size is 6
>> bytes and maybe that the multicast bit isn't set.

> Are you saying that some device trees have something *other* than a MAC 
> address in the 'address' property?

    'address' property was originally defined to hold a virtual address of the 
device registers (with 'reg' holding the physical address) until FSL decided 
to "reinvent" the property. :-)

WBR, Sergei