From: Sylvain Munaut <tnt@246tNt•com>
To: Hoang-Nam Nguyen <hnguyen@linux•vnet.ibm.com>
Cc: pmac@au1•ibm.com, fenkes@de•ibm.com,
linux-kernel@vger•kernel.org, linuxppc-dev@ozlabs•org,
paulus@samba•org, johnrose@us•ibm.com
Subject: Re: [PATCH 2.6.21-rc1] ibmebus: Use of_device_uevent()
Date: Sat, 17 Feb 2007 10:36:01 +0100 [thread overview]
Message-ID: <45D6CC81.1040004@246tNt.com> (raw)
In-Reply-To: <200702170356.12600.hnguyen@linux.vnet.ibm.com>
Hoang-Nam Nguyen wrote:
> This patch replaces ibmebus_uevent() by Sylvain's generic function.
>
> struct bus_type ibmebus_bus_type = {
> - .name = "ibmebus",
> - .uevent = ibmebus_uevent,
> - .match = ibmebus_bus_match,
> + .name = "ibmebus",
> + .uevent = of_device_uevent,
> + .match = ibmebus_bus_match,
> };
> EXPORT_SYMBOL(ibmebus_bus_type);
>
Doesn't that oops when called with the fake parent device ?
Either you do a wrapper that test for it (that's what I did when I
posted the patch).
Or, an even better approach is to add this
+ if (!ebus_dev->ofdev.node)
+ return -ENODEV;
inside the code of of_device_uevent itself.
Sylvain
next prev parent reply other threads:[~2007-02-17 9:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-17 2:56 [PATCH 2.6.21-rc1] ibmebus: Use of_device_uevent() Hoang-Nam Nguyen
2007-02-17 9:36 ` Sylvain Munaut [this message]
2007-02-17 15:53 ` Joachim Fenkes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45D6CC81.1040004@246tNt.com \
--to=tnt@246tnt$(echo .)com \
--cc=fenkes@de$(echo .)ibm.com \
--cc=hnguyen@linux$(echo .)vnet.ibm.com \
--cc=johnrose@us$(echo .)ibm.com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=paulus@samba$(echo .)org \
--cc=pmac@au1$(echo .)ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox