public inbox for linuxppc-dev@ozlabs.org 
 help / color / mirror / Atom feed
From: Geoff Levand <geoffrey.levand@am•sony.com>
To: Benjamin Herrenschmidt <benh@kernel•crashing.org>
Cc: linuxppc-dev@ozlabs•org, David Gibson <david@gibson•dropbear.id.au>
Subject: Re: [PATCH 3/3] zImage: Cleanup and improve zImage entry point
Date: Mon, 19 Feb 2007 12:37:56 -0800	[thread overview]
Message-ID: <45DA0AA4.3020107@am.sony.com> (raw)
In-Reply-To: <1171915022.18571.50.camel@localhost.localdomain>

Benjamin Herrenschmidt wrote:
>> This messed me up a bit since I had two stacks in the bss, one for each
>> processor thread.  By the time this was called on the primary thread the
>> secondary thread could already be using its stack.  I changed the secondary
>> thread to use a small stack in the data section, so this seems OK.
> 
> The secondary thread(s) don't need a stack to loop in secondary hold,
> right ? So maybe we could go all the way without using a stack. Do we
> need C code at all for them ? We just need to hold them until we make
> them branch to the kernel.

I thought it would be nice to be able to use printf() in there so you
see the following.  Its handy for debugging.

smp_secondary_hold:307: released cpu (1)


-Geoff

  reply	other threads:[~2007-02-19 20:38 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-16  6:24 [0/3] RFC: Cleanups and improvements to the zImage wrapper David Gibson
2007-02-16  6:27 ` [PATCH 1/3] zImage: Add more flexible gunzip convenience functions David Gibson
2007-02-16  6:27 ` [PATCH 2/3] zImage: Cleanup and improve prep_kernel() David Gibson
2007-02-18  1:22   ` Geoff Levand
2007-02-18  7:21     ` David Gibson
2007-02-16  6:27 ` [PATCH 3/3] zImage: Cleanup and improve zImage entry point David Gibson
2007-02-18  1:22   ` Geoff Levand
2007-02-18  7:23     ` David Gibson
2007-02-19  0:26       ` Paul Mackerras
2007-02-19  0:48         ` David Gibson
2007-02-19 15:14       ` Geoff Levand
2007-02-19 19:59         ` Benjamin Herrenschmidt
2007-02-19 19:57     ` Benjamin Herrenschmidt
2007-02-19 20:37       ` Geoff Levand [this message]
2007-02-19 20:50         ` Benjamin Herrenschmidt
2007-02-19 21:14           ` Geoff Levand
2007-02-16 16:47 ` [0/3] RFC: Cleanups and improvements to the zImage wrapper Geoff Levand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45DA0AA4.3020107@am.sony.com \
    --to=geoffrey.levand@am$(echo .)sony.com \
    --cc=benh@kernel$(echo .)crashing.org \
    --cc=david@gibson$(echo .)dropbear.id.au \
    --cc=linuxppc-dev@ozlabs$(echo .)org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox