Subject: Re: [PATCH] mpc52xx_pic: fix main interrupt masking

From: Sylvain Munaut <[email-masked]>
Date: Tue, 06 Mar 2007 11:02:17 +0100

Domen Puncer wrote:
> Fix main interrupt masking.
> Tested with RTC and GPIO_WKUP interrupts.
>
>
> Signed-off-by: Domen Puncer <[email-masked]>
>   
Acked-by: Sylvain Munaut <[email-masked]>

Damn, I knew I forgot something during the last batch ! That bug had
already been spotted earlier ...

> ---
>  arch/powerpc/platforms/52xx/mpc52xx_pic.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> Index: grant.git/arch/powerpc/platforms/52xx/mpc52xx_pic.c
> ===================================================================
> --- grant.git.orig/arch/powerpc/platforms/52xx/mpc52xx_pic.c
> +++ grant.git/arch/powerpc/platforms/52xx/mpc52xx_pic.c
> @@ -128,7 +128,7 @@ static void mpc52xx_main_mask(unsigned i
>  
>  	pr_debug("%s: irq=%x. l2=%d\n", __func__, irq, l2irq);
>  
> -	io_be_setbit(&intr->main_mask, 15 - l2irq);
> +	io_be_setbit(&intr->main_mask, 16 - l2irq);
>  }
>  
>  static void mpc52xx_main_unmask(unsigned int virq)
> @@ -141,7 +141,7 @@ static void mpc52xx_main_unmask(unsigned
>  
>  	pr_debug("%s: irq=%x. l2=%d\n", __func__, irq, l2irq);
>  
> -	io_be_clrbit(&intr->main_mask, 15 - l2irq);
> +	io_be_clrbit(&intr->main_mask, 16 - l2irq);
>  }
>  
>  static struct irq_chip mpc52xx_main_irqchip = {
> _______________________________________________
> Linuxppc-embedded mailing list
> [email-masked]
> https://ozlabs.org/mailman/listinfo/linuxppc-embedded
>
>