From: Sergei Shtylyov <sshtylyov@ru•mvista.com>
To: Felix Domke <tmbinc@elitedvb•net>
Cc: Linuxppc-dev@ozlabs•org, Linux IDE <linux-ide@vger•kernel.org>
Subject: Re: [patch 5/7] xenon: add SATA support
Date: Thu, 08 Mar 2007 00:14:35 +0300 [thread overview]
Message-ID: <45EF2B3B.7030306@ru.mvista.com> (raw)
In-Reply-To: <45EF2985.1020407@elitedvb.net>
Felix Domke wrote:
>>Felix Domke wrote:
>>>This adds support for the HDD and DVD SATA controller on the xenon
>>>southbridge.
>> Pleas post this to linux-ide@vger•kernel.org in the future.
> I'll do.
>>>It also disables ATA_TFLAG_POLLING in libata-core, which prevented the
>>>DVD drive
>>>from being detected. It needs to be investigated what exactly is wrong
>>>here.
>>> tf.protocol = ATA_PROT_PIO;
>>>- tf.flags |= ATA_TFLAG_POLLING; /* for polling presence detection */
>>>+// tf.flags |= ATA_TFLAG_POLLING; /* for polling presence
>>>detection */
>> I doubt that this could *ever* get accepted.
> It was not meant to be accepted, but to work around the problem which
> was introduced in 2.6.19. I have far too less knowledge of the SATA
> layer to understand why this flag exactly causes the detection of the
> DVD-Drive fail.
> As said, this needs to be investigated, and fixed (in the driver, of
> course, not in the subsystem).
Yeah, I've missed it in the patch description. :-<
>>>+static unsigned int get_scr_cfg_addr(unsigned int port_no, unsigned
>>>int sc_reg, int device)
>>>+{
>>>+ unsigned int addr = SIS_SCR_BASE + (4 * sc_reg);
>>>+
>> Why we need device and port_no arguments here?
> As there is only one device/port per PCI device, the arguments should
> probably be removed from this function, right.
>>>+ if (sc_reg == SCR_ERROR) /* doesn't exist in PCI cfg space */
>>>+ return 0; /* assume no error */
>>
>> Since SCR_ERROR == 1, this check seems broken.
> Why?
Since get_scr_cfg_addr() will never return 1... oh wait, we're checking
another variable... :-<
Maybe worth merging to get_scr_cfg_addr() then, along with (sc_reg >
SCR_CONTROL) checks, to avoid duplicate code.
> Felix
MBR, Sergei
next prev parent reply other threads:[~2007-03-07 21:14 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-07 18:01 [patch 0/7] [RFC] Xenon support Felix Domke
2007-03-07 18:01 ` [patch 1/7] xenon: add PCI Vendor ID: Microsoft Felix Domke
2007-03-07 18:01 ` [patch 2/7] xenon: add platform support Felix Domke
2007-03-07 23:06 ` Arnd Bergmann
2007-03-07 18:01 ` [patch 3/7] xenon: udbg support (ugly) Felix Domke
2007-03-07 21:00 ` Geert Uytterhoeven
2007-03-07 18:01 ` [patch 4/7] xenon: add southbridge ethernet support Felix Domke
2007-03-07 23:27 ` Arnd Bergmann
2007-03-07 18:01 ` [patch 5/7] xenon: add SATA support Felix Domke
2007-03-07 21:02 ` Sergei Shtylyov
2007-03-07 21:07 ` Felix Domke
2007-03-07 21:14 ` Sergei Shtylyov [this message]
2007-03-07 18:01 ` [patch 6/7] xenon: add SMC support Felix Domke
2007-03-07 21:54 ` Arnd Bergmann
2007-03-08 23:29 ` Linas Vepstas
2007-03-07 18:01 ` [patch 7/7] xenon: add framebuffer support (ugly) Felix Domke
2007-03-07 21:06 ` [patch 0/7] [RFC] Xenon support Josh Boyer
2007-03-07 21:14 ` Felix Domke
2007-03-08 9:48 ` Benjamin Herrenschmidt
2007-03-08 0:35 ` Stephen Rothwell
2007-03-08 0:52 ` Felix Domke
2007-03-08 11:02 ` Christoph Hellwig
2007-03-08 23:50 ` Linas Vepstas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45EF2B3B.7030306@ru.mvista.com \
--to=sshtylyov@ru$(echo .)mvista.com \
--cc=Linuxppc-dev@ozlabs$(echo .)org \
--cc=linux-ide@vger$(echo .)kernel.org \
--cc=tmbinc@elitedvb$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox