Subject: Re: [PATCH 3/5 v2] mpc52xx suspend: USB

From: Sylvain Munaut <[email-masked]>
Date: Fri, 23 Mar 2007 12:56:47 +0100

Domen Puncer wrote:
> +	struct usb_hcd *hcd = dev_get_drvdata(&op->dev);
> +	if (machine_is_compatible("generic-mpc5200")) {
> +		struct ohci_hcd *ohci = hcd_to_ohci(hcd);
>
>   
Not good, what if you have a Ohci PCI card on a 5200 board ...

You somehow need to check the compatible list of the of_node associated
with the particular instance you're putting to sleep.

    Sylvain