From: Geoff Levand <geoffrey.levand@am•sony.com>
To: Milton Miller <miltonm@bga•com>
Cc: linuxppc-dev@ozlabs•org, Paul Mackerras <paulus@samba•org>
Subject: Re: [PATCH 8/9] ps3: cleanup ps3fb before clearing HPTE
Date: Mon, 26 Mar 2007 18:06:33 -0700 [thread overview]
Message-ID: <46086E19.4010609@am.sony.com> (raw)
In-Reply-To: <e1f83c095fc09e65524d4a8800c36120@bga.com>
Milton Miller wrote:
> Paul, after reading this note I send a big fat
>
> NACK
>
> to this patch.
Sorry for not being more clear. That was what I was kind of
saying, that there is something strange here, and I am looking
into it.
> On Mar 24, 2007, at 6:46 PM, Geoff Levand wrote:
>
>> Christoph Hellwig wrote:
>>>>> static void ps3_hpte_clear(void)
>>>> {
>>>> +
>>>> +#ifdef CONFIG_FB_PS3
>>>> + ps3fb_cleanup();
>>>> +#endif
>>>
>>> And well, adding framebuffer calls into the mmu code is rather fucked.
>>> This at least needs a big comment explaning the hypervisor braindamage
>>> that is responsible for this in colourfull language.
>>
>> Sorry for such a late reply, but I'm now doing the kexec code and see
>> why it was put here (by the original author). It is so you will have
>> debugging output until the very last possible moment during a kexec
>> shutdown.
>
> But that is REALLY to late for that.
>
>> The real problem is really that this routine (and the corresponding
>> ppc_md
>> variable) are inappropriately named.
>
> Ok, this should be
> ppc_md.kexec_cleanup_nothing_but_static_data_bss_real_mode_cleanup()
>
>
>> In the general case all that is left
>> to do is to call ppc_md.hpte_clear_all, but for ps3 we also want to do
>> the
>> framebuffer shutdown here, so something like this should be better:
>>
>> -static void ps3_hpte_clear(void)
>> +static void ps3_kexec_final(void)
>>
>> - ppc_md.hpte_clear_all = ps3_hpte_clear;
>> + ppc_md.hpte_clear_all = ps3_kexec_final;
>>
>
> NACK.
Yes, I just wanted to report why this strange code was in ps3_hpte_clear,
since Christoph never did get an answer, and give my idea on what might
work. This is not a solution, just a thought. I haven't really got
into it enough to say what the best way would be. Thanks for the
comments though.
> Oh, I just looked at your ps3 kexec hooks. Your ps3_kexec_cpu_down
> looks
> totally broken.
Yes, disregard anything you find regarding kexec on ps3. I'll post
some new stuff for review, hopefully sometime soon.
-Geoff
next prev parent reply other threads:[~2007-03-27 1:06 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-25 17:46 [PATCH 0/9] ps3av/fb drivers for 2.6.21 Geert Uytterhoeven
2007-01-25 17:48 ` [PATCH 1/9] ps3: AV Settings Driver Geert Uytterhoeven
2007-01-26 3:12 ` Christoph Hellwig
2007-01-29 14:10 ` Geert Uytterhoeven
2007-01-29 16:15 ` Christoph Hellwig
2007-01-29 19:24 ` Geoff Levand
2007-01-30 18:39 ` Segher Boessenkool
2007-01-30 19:39 ` Geert Uytterhoeven
2007-01-31 8:45 ` Christoph Hellwig
2007-01-26 4:13 ` Arnd Bergmann
2007-01-26 14:56 ` Geert Uytterhoeven
2007-01-28 21:37 ` Benjamin Herrenschmidt
2007-01-29 15:14 ` Geert Uytterhoeven
2007-01-30 0:16 ` Arnd Bergmann
2007-01-25 17:48 ` [PATCH 2/9] fbdev modedb: allow refresh rates for named video modes Geert Uytterhoeven
2007-01-25 17:49 ` [PATCH 3/9] fbdev modedb: make more pointer parameters const Geert Uytterhoeven
2007-01-25 17:49 ` [PATCH 4/9] fb_videomode_to_var: reset virtual screen parameters Geert Uytterhoeven
2007-01-25 17:50 ` [PATCH 5/9] ps3: Preallocate bootmem memory for ps3fb Geert Uytterhoeven
2007-01-30 2:29 ` Michael Ellerman
2007-01-30 8:16 ` Geert Uytterhoeven
2007-01-30 8:27 ` Arnd Bergmann
2007-01-30 8:36 ` Geert Uytterhoeven
2007-01-30 9:08 ` Benjamin Herrenschmidt
2007-01-30 10:44 ` Arnd Bergmann
2007-01-30 22:37 ` Michael Ellerman
2007-01-25 17:50 ` [PATCH 6/9] ps3: Virtual Frame Buffer Driver Geert Uytterhoeven
2007-01-25 21:36 ` [Linux-fbdev-devel] " Bernhard Fischer
2007-01-25 17:51 ` [PATCH 7/9] ps3: disable display flipping during mode changes Geert Uytterhoeven
2007-01-26 2:13 ` Arnd Bergmann
2007-01-25 17:51 ` [PATCH 8/9] ps3: cleanup ps3fb before clearing HPTE Geert Uytterhoeven
2007-01-26 3:14 ` Christoph Hellwig
2007-01-30 2:23 ` Michael Ellerman
2007-03-24 23:46 ` Geoff Levand
2007-03-25 17:43 ` Milton Miller
2007-03-27 1:06 ` Geoff Levand [this message]
2007-03-27 17:35 ` Christoph Hellwig
2007-01-25 17:52 ` [PATCH 9/9] ps3: ps3av/fb defconfig updates Geert Uytterhoeven
2007-01-25 17:55 ` [PATCH 0/9] ps3av/fb drivers for 2.6.21 Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46086E19.4010609@am.sony.com \
--to=geoffrey.levand@am$(echo .)sony.com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=miltonm@bga$(echo .)com \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox