From: Sylvain Munaut <tnt@246tNt•com>
To: John Rigby <jcrigby@gmail•com>
Cc: Linuxppc-embedded <Linuxppc-embedded@ozlabs•org>
Subject: Re: [PATCH] Avoid putting cpu node twice
Date: Sat, 07 Apr 2007 20:22:46 +0200 [thread overview]
Message-ID: <4617E176.6040607@246tNt.com> (raw)
In-Reply-To: <4b73d43f0704061557v2f38991ep54bc66706672075d@mail.gmail.com>
John Rigby wrote:
> Call of_find_node_by_type with NULL instead of np
> so the cpu node does not get put twice.
> This was causing kref_put warnings.
>
> Signed-off-by: John Rigby <jrigby@freescale•com>
Acked-by: Sylvain Munaut <tnt@246tNt•com>
> ---
> arch/powerpc/platforms/52xx/lite5200.c | 6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/arch/powerpc/platforms/52xx/lite5200.c
> b/arch/powerpc/platforms/52xx/lite5200.c
> index cc3b40d..d2f90eb 100644
> --- a/arch/powerpc/platforms/52xx/lite5200.c
> +++ b/arch/powerpc/platforms/52xx/lite5200.c
> @@ -108,9 +108,11 @@ static void __init lite5200_setup_arch(void)
> lite5200_setup_cpu(); /* Platorm specific */
>
> #ifdef CONFIG_PCI
> - np = of_find_node_by_type(np, "pci");
> - if (np)
> + np = of_find_node_by_type(NULL, "pci");
> + if (np) {
> mpc52xx_add_bridge(np);
> + of_node_put(np);
> + }
> #endif
>
> #ifdef CONFIG_BLK_DEV_INITRD
> --
> 1.5.0.6
>
next prev parent reply other threads:[~2007-04-07 18:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-06 22:57 [PATCH] Avoid putting cpu node twice John Rigby
2007-04-07 18:22 ` Sylvain Munaut [this message]
2007-04-27 16:39 ` Fwd: " John Rigby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4617E176.6040607@246tNt.com \
--to=tnt@246tnt$(echo .)com \
--cc=Linuxppc-embedded@ozlabs$(echo .)org \
--cc=jcrigby@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox