From: Andrei Konovalov <akonovalov@ru•mvista.com>
To: Grant Likely <grant.likely@secretlab•ca>
Cc: linuxppc-embedded@ozlabs•org
Subject: Re: [PATCH] Xilinx framebuffer device driver
Date: Wed, 25 Apr 2007 22:16:58 +0400 [thread overview]
Message-ID: <462F9B1A.3090906@ru.mvista.com> (raw)
In-Reply-To: <462F98B4.2000108@ru.mvista.com>
Grant,
Andrei Konovalov wrote:
> I could add these to platform data.
> Together with the "use DCR access" option.
> Say,
>
> --------------------------------------------------------
> struct xilinxfb_platform_data {
> u32 use_dcr;
> u32 screen_height_mm;
> u32 screen_width_mm;
> };
>
> static struct xilinxfb_platform_data xilinxfb_pdata = {
> #if defined(XPAR_TFT_0_USE_DCR) && (XPAR_TFT_0_USE_DCR != 0)
> .use_dcr = 1;
> #else
> .use_dcr = 0;
> #endif
IOW I am trying to avoid conditional compilation like:
#if defined(XPAR_TFT_0_USE_DCR) && (XPAR_TFT_0_USE_DCR != 0)
#define xilinxfb_out_be32(addr, mask) mtdcr((addr), (mask))
#else
#define xilinxfb_out_be32(addr, mask) out_be32((addr), (mask))
#endif
- as this would make the driver to include xparameters.h which would
be an issue when moving to the OF device tree.
Or "use DCR" could be a Kconfig option for the driver.
Thanks,
Andrei
next prev parent reply other threads:[~2007-04-25 18:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-24 13:59 [PATCH] Xilinx framebuffer device driver Andrei Konovalov
2007-04-24 14:41 ` Peter Mendham
2007-04-24 22:17 ` Grant Likely
2007-04-25 13:06 ` Andrei Konovalov
2007-04-24 22:35 ` Arnd Bergmann
2007-04-25 18:06 ` Andrei Konovalov
2007-04-25 18:16 ` Andrei Konovalov [this message]
2007-04-25 18:35 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=462F9B1A.3090906@ru.mvista.com \
--to=akonovalov@ru$(echo .)mvista.com \
--cc=grant.likely@secretlab$(echo .)ca \
--cc=linuxppc-embedded@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox