From: Dave Jiang <djiang@mvista•com>
To: Kumar Gala <galak@kernel•crashing.org>
Cc: linuxppc-dev@ozlabs•org, bluesmoke-devel@lists•sourceforge.net,
david@gibson•dropbear.id.au
Subject: Re: [PATCH] powerpc: Add EDAC platform devices for 85xx
Date: Thu, 26 Apr 2007 09:56:11 -0700 [thread overview]
Message-ID: <4630D9AB.2040605@mvista.com> (raw)
In-Reply-To: <9903F55A-5E4E-42CE-8C27-6B7143B9FE25@kernel.crashing.org>
Kumar Gala wrote:
> On Apr 25, 2007, at 7:37 PM, Dave Jiang wrote:
>
>
>> + mem-ctrl@2000 {
>> + device_type = "mem-ctrl";
>> + compatible = "85xx";
>>
> I'm concerned this is too generic.
>
I'm supposing not all 85xx uses the same soc? Is there something more
appropriate you can suggest? Thx!
>> + reg = <2000 1000>;
>> + interrupt-parent = <&mpic>;
>> + interrupts = <2 2>;
>> + };
>> +
>> + l2-cache@20000 {
>> + device_type = "l2-cache";
>> + compatible = "85xx";
>> + reg = <20000 1000>;
>> + cache-line-size = <20>; // 32 bytes
>> + cache-size = <40000>; // L2, 256K
>> + 32-bit;
>>
>
> Why the 32-bit?
>
No reason particular. Bad assumption. I will remove it.
>> diff --git a/arch/powerpc/sysdev/fsl_soc.c b/arch/powerpc/sysdev/
>> fsl_soc.c
>> index 8a123c7..a0beb8b 100644
>> --- a/arch/powerpc/sysdev/fsl_soc.c
>> +++ b/arch/powerpc/sysdev/fsl_soc.c
>> @@ -1103,3 +1103,118 @@ err:
>> arch_initcall(cpm_smc_uart_of_init);
>>
>> #endif /* CONFIG_8xx */
>> +
>> +/* platform device setup for EDAC */
>>
>
> Why not have the EDAC code for 85xx use of_device?
>
>
I will give that a try.
next prev parent reply other threads:[~2007-04-26 16:55 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-25 21:37 [PATCH] powerpc: Add EDAC platform devices for 85xx Dave Jiang
2007-04-26 0:08 ` David Gibson
2007-04-26 0:37 ` Dave Jiang
2007-04-26 14:31 ` Kumar Gala
2007-04-26 16:56 ` Dave Jiang [this message]
2007-04-26 18:56 ` Segher Boessenkool
2007-05-01 15:11 ` RFC: new device types in the device tree (RE: [PATCH] powerpc: Add EDAC platform devices for 85xx) Yoder Stuart-B08248
2007-05-02 0:34 ` Segher Boessenkool
2007-05-02 1:19 ` David Gibson
2007-05-02 19:04 ` Yoder Stuart-B08248
2007-05-03 0:17 ` David Gibson
2007-05-03 0:55 ` Segher Boessenkool
2007-05-04 15:29 ` Yoder Stuart-B08248
2007-05-03 0:54 ` Segher Boessenkool
2007-05-02 18:50 ` Yoder Stuart-B08248
2007-05-03 0:48 ` Segher Boessenkool
2007-05-04 15:16 ` Yoder Stuart-B08248
2007-05-05 0:07 ` Segher Boessenkool
2007-04-30 17:37 ` [PATCH] powerpc: Add EDAC platform devices for 85xx Dave Jiang
2007-05-01 18:32 ` [PATCH] powerpc: publish 85xx soc devices as of_device on cds and ads Dave Jiang
2007-05-07 23:26 ` [PATCH] powerpc: add dts entries to 85xx for EDAC Dave Jiang
2007-05-08 3:42 ` Olof Johansson
2007-05-08 17:34 ` Dave Jiang
2007-05-08 13:16 ` Kumar Gala
2007-05-08 17:08 ` Dave Jiang
2007-05-09 14:40 ` Segher Boessenkool
2007-05-09 16:53 ` Dave Jiang
2007-05-10 5:25 ` Kumar Gala
2007-05-10 17:03 ` Dave Jiang
2007-05-15 18:20 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4630D9AB.2040605@mvista.com \
--to=djiang@mvista$(echo .)com \
--cc=bluesmoke-devel@lists$(echo .)sourceforge.net \
--cc=david@gibson$(echo .)dropbear.id.au \
--cc=galak@kernel$(echo .)crashing.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox