From: Arnd Bergmann <arnd@arndb•de>
To: Suman Tripathi <stripathi@apm•com>
Cc: "devicetree@vger•kernel.org" <devicetree@vger•kernel.org>,
Mark Langsdorf <mlangsdo@redhat•com>,
"jcm@redhat•com" <jcm@redhat•com>,
Anton Vorontsov <anton@enomsg•org>,
"linux-mmc@vger•kernel.org" <linux-mmc@vger•kernel.org>,
"chris@printf•net" <chris@printf•net>,
Michal Simek <michal.simek@xilinx•com>,
"patches@apm•com" <patches@apm•com>,
Rob Herring <robherring2@gmail•com>,
Don Dutile <ddutile@redhat•com>,
linuxppc-dev <linuxppc-dev@lists•ozlabs.org>,
"linux-arm-kernel@lists•infradead.org"
<linux-arm-kernel@lists•infradead.org>
Subject: Re: [PATCH v5 1/1] arm64: dts: Add the arasan sdhc nodes in apm-storm.dtsi.
Date: Wed, 06 May 2015 09:31:42 +0200 [thread overview]
Message-ID: <4635229.bceBxngCoe@wuerfel> (raw)
In-Reply-To: <CAOHikRC1dYd0BqhUCzdeZ8=PhSOj77sQR9kzrM8Gus3AJS1ejw@mail.gmail.com>
On Wednesday 06 May 2015 10:41:07 Suman Tripathi wrote:
> >> @@ -533,6 +567,16 @@
> >> interrupts = <0x0 0x4f 0x4>;
> >> };
> >>
> >> + sdhc0: sdhc@1c000000 {
> >> + device_type = "sdhc";
> >
> > device_type generally should not be used (there are a few exceptions).
>
> Okay !!
>
While we're at it, please change sdhc@1c000000 to mmc@1c000000.
Even though Linux does not care, we try to use the standard device
names for consistency.
Arnd
next prev parent reply other threads:[~2015-05-06 7:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-05 9:17 [PATCH v5 0/1] Add SDHCI support for APM X-Gene SoC using ARASAN SDHCI controller Suman Tripathi
2015-05-05 9:17 ` [PATCH v5 1/1] arm64: dts: Add the arasan sdhc nodes in apm-storm.dtsi Suman Tripathi
2015-05-05 10:34 ` Ulf Hansson
2015-05-06 9:49 ` Ulf Hansson
2015-05-05 19:41 ` Rob Herring
2015-05-06 5:11 ` Suman Tripathi
2015-05-06 7:31 ` Arnd Bergmann [this message]
2015-05-06 7:45 ` Michal Simek
2015-05-06 8:40 ` Arnd Bergmann
2015-05-06 11:57 ` Suman Tripathi
2015-05-06 12:01 ` Suman Tripathi
2015-05-06 12:41 ` Michal Simek
2015-05-06 12:47 ` Suman Tripathi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4635229.bceBxngCoe@wuerfel \
--to=arnd@arndb$(echo .)de \
--cc=anton@enomsg$(echo .)org \
--cc=chris@printf$(echo .)net \
--cc=ddutile@redhat$(echo .)com \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=jcm@redhat$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-mmc@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=michal.simek@xilinx$(echo .)com \
--cc=mlangsdo@redhat$(echo .)com \
--cc=patches@apm$(echo .)com \
--cc=robherring2@gmail$(echo .)com \
--cc=stripathi@apm$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox