From: Geoff Levand <geoffrey.levand@am•sony.com>
To: Paul Mackerras <paulus@samba•org>
Cc: linuxppc-dev@ozlabs•org
Subject: [patch 1/6] PS3: Remove dev_dbg redefinition in ehci-ps3.c and ohci-ps3.c
Date: Mon, 30 Apr 2007 14:00:46 -0700 [thread overview]
Message-ID: <463658FE.8050700@am.sony.com> (raw)
In-Reply-To: <20070430202420.872228544@am.sony.com>
Commit 404d5b185b4eb56d6fa2f7bd27833f8df1c38ce4 changed the definition
of dev_dbg in the !DEBUG case from being a #define to being a static
inline. There was code in usb/host/ehci-ps3.c and ohci-ps3.c to do
exactly that, which fails to compile now. This fixes it by removing
the redefinition, as the redefinition is now superfluous.
Signed-off-by: Geoff Levand <geoffrey.levand@am•sony.com>
---
drivers/usb/host/ehci-ps3.c | 7 -------
drivers/usb/host/ohci-ps3.c | 8 --------
2 files changed, 15 deletions(-)
--- ps3-linux-dev.orig/drivers/usb/host/ehci-ps3.c
+++ ps3-linux-dev/drivers/usb/host/ehci-ps3.c
@@ -73,13 +73,6 @@ static const struct hc_driver ps3_ehci_h
#endif
};
-#if !defined(DEBUG)
-#undef dev_dbg
-static inline int __attribute__ ((format (printf, 2, 3))) dev_dbg(
- const struct device *_dev, const char *fmt, ...) {return 0;}
-#endif
-
-
static int ps3_ehci_sb_probe(struct ps3_system_bus_device *dev)
{
int result;
--- ps3-linux-dev.orig/drivers/usb/host/ohci-ps3.c
+++ ps3-linux-dev/drivers/usb/host/ohci-ps3.c
@@ -75,14 +75,6 @@ static const struct hc_driver ps3_ohci_h
#endif
};
-/* redefine dev_dbg to do a syntax check */
-
-#if !defined(DEBUG)
-#undef dev_dbg
-static inline int __attribute__ ((format (printf, 2, 3))) dev_dbg(
- const struct device *_dev, const char *fmt, ...) {return 0;}
-#endif
-
static int ps3_ohci_sb_probe(struct ps3_system_bus_device *dev)
{
int result;
--
next parent reply other threads:[~2007-04-30 21:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070430202420.872228544@am.sony.com>
2007-04-30 21:00 ` Geoff Levand [this message]
2007-04-30 21:00 ` [patch 2/6] PS3: Add DABR support Geoff Levand
2007-04-30 21:00 ` [patch 3/6] PS3: Remove duplicate variable assignement Geoff Levand
2007-04-30 21:01 ` [patch 4/6] PS3: Interrupt routine fixups Geoff Levand
2007-04-30 21:01 ` [patch 5/6] PS3: Fix system slowdown Geoff Levand
2007-05-01 5:31 ` Benjamin Herrenschmidt
2007-04-30 21:01 ` [patch 6/6] PS3: Defconfig updates Geoff Levand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=463658FE.8050700@am.sony.com \
--to=geoffrey.levand@am$(echo .)sony.com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox